Bug 1445719

Summary: Review Request: perl-Net-LibIDN2 - Perl binding for GNU Libidn2
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Net-LibIDN2-0.03-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-28 05:47:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2017-04-26 11:28:55 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Net-LibIDN2/perl-Net-LibIDN2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Net-LibIDN2/perl-Net-LibIDN2-0.03-1.fc27.src.rpm
Description:
This Perl module provides bindings for GNU Libidn2, a C library for handling
internationalized domain names according to IDNA 2008 (RFC 5890, RFC 5891,
RFC 5892, RFC 5893).

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-04-26 14:56:40 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-LibIDN2-0.03-1.fc27.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libidn2.so.0()(64bit)
      1 libidn2.so.0(IDN2_0.0.0)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Net-LibIDN2-0.03-1.fc27.x86_64.rpm | sort | uniq -c
      1 perl(Net::LibIDN2) = 0.03
      1 perl-Net-LibIDN2 = 0.03-1.fc27
      1 perl-Net-LibIDN2(x86-64) = 0.03-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Net-LibIDN2*
perl-Net-LibIDN2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-Net-LibIDN2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved
Comment 2 Gwyn Ciesla 2017-04-27 12:40:01 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LibIDN2
Comment 3 Petr Pisar 2017-04-28 05:47:58 UTC 
Thank you for the review and the repository.