Bug 1445735

Summary:	Add provider: No validation for non 'default' tab on init
Product:	Red Hat CloudForms Management Engine	Reporter:	Mooli Tayer <mtayer>
Component:	UI - OPS	Assignee:	Aparna Karve <akarve>
Status:	CLOSED ERRATA	QA Contact:	Einat Pacifici <epacific>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	akarve, cpelland, dclarizi, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-01 13:12:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	Container Management	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1437138

Description Mooli Tayer 2017-04-26 12:13:45 UTC

Description of problem:
In the add provider page for all providers, when there is more then one endpoint the first tab starts as non valid with a red marker next to the tab name.
You can then fill in the first tab and add the provider.

The reason i'm pretty sure this is not intentional is that if you go to a secondary tab, press inside an input element and then out side they tab will switch to invalid. 


Version-Release number of selected component (if applicable):
5.8.12

How reproducible:
100%

Steps to Reproduce:
1. Go to compute/containers -> add provider

Actual results:
- 'default' tab has red error marker next to tab name. 'hawkular' tab does not
- after filling in & validating only the 'default' endpoint it is possible to add the provider

Expected results:
- both tabs should start with the error marker.
- it should not be possible to add a provider with out filling and validating both endpoints

Comment 2 Mooli Tayer 2017-04-26 16:29:06 UTC

Creating both a rhev provider without going to the second tab will result in:
> x.connection_configurations[:metrics].hostname
 => nil 

Doing the same with a container provider will result in
> x.connection_configurations['hawkular'].port
 => nil

These are both malformed endpoints

Comment 3 CFME Bot 2017-04-26 20:23:29 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/1172

Comment 4 CFME Bot 2017-04-27 19:23:03 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/e5bc4751cf256203cd8c91f26f120833f71fbee2

commit e5bc4751cf256203cd8c91f26f120833f71fbee2
Author:     Aparna Karve <akarve>
AuthorDate: Wed Apr 26 12:55:11 2017 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Wed Apr 26 12:55:11 2017 -0700

    Ensure that the Hawkular tab displays an error indicator
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445735

 .../javascripts/controllers/ems_common/ems_common_form_controller.js    | 2 +-
 app/controllers/mixins/ems_common_angular.rb                            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment 9 errata-xmlrpc 2018-03-01 13:12:04 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380