Bug 1445784

Summary:	Container Review Request: php - Platform for building and running PHP applications
Product:	[Fedora] Fedora Container Images	Reporter:	rpitonak
Component:	Container Review	Assignee:	Honza Horak <hhorak>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	25	CC:	container-review, hhorak
Target Milestone:	---	Flags:	hhorak: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-20 22:44:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description rpitonak 2017-04-26 14:04:05 UTC

Dockerfile URL: https://github.com/container-images/php/blob/master/Dockerfile

Other files URL: https://github.com/container-images/php

Description:
This container image provides a platform for building and running PHP application as a reproducible image using source-to-image. PHP is a widely-used open source general-purpose scripting language that is especially suited for web development and can be embedded into HTML.

Fedora Account System Username: rpitonak

Comment 1 Honza Horak 2017-05-17 05:47:09 UTC

Two issues spotted:

1) The image is s2i (which is correct), but uses

  FROM registry.fedoraproject.org/fedora:25

..which would duplicate common s2i stuff. I'd suggest to use s2i-base as the base image:

  FROM registry.fedoraproject.org/f25/s2i-base

2) MAINTAINER statement is obsolete, we should use LABEL MAINTAINER instead.

But none of them is a blocker for the review, so IMO we can ack this.

Comment 2 Gwyn Ciesla 2017-05-25 12:21:46 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/php

Comment 3 Honza Horak 2017-08-20 22:44:41 UTC

The image is built, closing this request.