Bug 1445824

Summary:	Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests
Product:	[Fedora] Fedora	Reporter:	Björn Esser (besser82) <besser82>
Component:	Package Review	Assignee:	Christian Dersch <lupinix.fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	david.hannequin, lupinix.fedora, package-review
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	lupinix.fedora: fedora-review+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-25 21:22:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1445822
Bug Blocks:	1124239

Description Björn Esser (besser82) 2017-04-26 15:09:02 UTC

Description:

  TestFixtures is a collection of helpers and mock objects that are
  useful when writing unit tests or doc tests.

  If you’re wondering why “yet another mock object library”, testing
  is often described as an art form and as such some styles of library
  will suit some people while others will suit other styles.  This
  library contains common test fixtures the author found himself
  repeating from package to package and so decided to extract them
  into their own library and give them some tests of their own!


Koji Build:

  None, missing dependency up for review.


Issues:

  No known issues.  Rpmlint has some false positive complaints.


FAS-User:

  besser82


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures-4.13.5-0.1.fc27.src.rpm


Thanks for review in advance!

Comment 1 Christian Dersch 2017-04-26 15:58:40 UTC

Not approved, rpmlint reports an issue that should be fixed.


Package Review                                                                                                                                               
==============                                                                                                                                               
                                                                                                                                                             
Legend:                                                                                                                                                      
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated                                                                                            
[ ] = Manual review needed                                                                                                                                   
                                                                                                                                                             
                                                                                                                                                             
Issues:                                                                                                                                                      
=======                                                                                                                                                      
- check rpmlint messages, there are reports of type:                                                                                                         
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/comparison.pyc expected 3379 (3.6), found 62211 (2.7)                                                                                                                                                     


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 78 files have
     unknown license. Detailed output of licensecheck in
     /home/review/1445824-python-testfixtures/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.6/site-
     packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
==> is noarch

[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     testfixtures-doc , python2-testfixtures , python2-testfixtures-tests ,
     python3-testfixtures , python3-testfixtures-tests
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
==> noarch

[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-testfixtures-doc-4.13.5-0.1.fc27.noarch.rpm
          python2-testfixtures-4.13.5-0.1.fc27.noarch.rpm
          python2-testfixtures-tests-4.13.5-0.1.fc27.noarch.rpm
          python3-testfixtures-4.13.5-0.1.fc27.noarch.rpm
          python3-testfixtures-tests-4.13.5-0.1.fc27.noarch.rpm
          python-testfixtures-4.13.5-0.1.fc27.src.rpm
python2-testfixtures-tests.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite
python2-testfixtures-tests.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite
python2-testfixtures-tests.noarch: W: no-documentation
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/comparison.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/shouldwarn.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/popen.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/tdatetime.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/compat.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/__init__.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/utils.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/resolve.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/components.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/tempdirectory.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/logcapture.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/manuel.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/replace.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/outputcapture.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/shouldraise.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/rmtree.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures-tests.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite
python3-testfixtures-tests.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite
python3-testfixtures-tests.noarch: W: no-documentation
6 packages and 0 specfiles checked; 16 errors, 6 warnings.

===> Looks like something went wrong here :( Please check the python-bytecode-wrong-magic-value issue


Rpmlint (installed packages)
----------------------------
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/__init__.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/comparison.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/compat.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/components.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/logcapture.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/manuel.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/outputcapture.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/popen.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/replace.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/resolve.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/rmtree.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/shouldraise.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/shouldwarn.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/tdatetime.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/tempdirectory.pyc expected 3379 (3.6), found 62211 (2.7)
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/testfixtures/utils.pyc expected 3379 (3.6), found 62211 (2.7)
python2-testfixtures-tests.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite
python2-testfixtures-tests.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite
python2-testfixtures-tests.noarch: W: no-documentation
python3-testfixtures-tests.noarch: W: spelling-error Summary(en_US) Testsuite -> Test suite, Test-suite, Suite
python3-testfixtures-tests.noarch: W: spelling-error %description -l en_US testsuite -> test suite, test-suite, suite
python3-testfixtures-tests.noarch: W: no-documentation
5 packages and 0 specfiles checked; 16 errors, 6 warnings.

====> Same as above, python-bytecode-wrong-magic-value issue

Requires
--------
python3-testfixtures (rpmlib, GLIBC filtered):
    python(abi)

python-testfixtures-doc (rpmlib, GLIBC filtered):

python2-testfixtures (rpmlib, GLIBC filtered):
    python(abi)

python2-testfixtures-tests (rpmlib, GLIBC filtered):
    python(abi)
    python-coveralls
    python-manuel
    python-mock
    python-nose
    python-nose-cov
    python-nose_fixes
    python-pkginfo
    python-setuptools
    python-setuptools_git
    python-sphinx
    python-twine
    python-wheel
    python-zope-component
    python2-testfixtures

python3-testfixtures-tests (rpmlib, GLIBC filtered):
    python(abi)
    python3-coveralls
    python3-manuel
    python3-mock
    python3-nose
    python3-nose-cov
    python3-nose_fixes
    python3-pkginfo
    python3-setuptools
    python3-setuptools_git
    python3-sphinx
    python3-testfixtures
    python3-twine
    python3-wheel
    python3-zope-component



Provides
--------
python3-testfixtures:
    python3-testfixtures
    python3.6dist(testfixtures)
    python3dist(testfixtures)

python-testfixtures-doc:
    python-testfixtures-doc

python2-testfixtures:
    python-testfixtures
    python2-testfixtures
    python2.7dist(testfixtures)
    python2dist(testfixtures)

python2-testfixtures-tests:
    python-testfixtures-tests
    python2-testfixtures-tests

python3-testfixtures-tests:
    python3-testfixtures-tests



Source checksums
----------------
https://files.pythonhosted.org/packages/source/t/testfixtures/testfixtures-4.13.5.tar.gz :
  CHECKSUM(SHA256) this package     : b257c9877fe7829115efc4949635de4a5fa79bf9160db34988c9f166b2e78987
  CHECKSUM(SHA256) upstream package : b257c9877fe7829115efc4949635de4a5fa79bf9160db34988c9f166b2e78987


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -L rpm_deps/ -m fedora-rawhide-x86_64 -b 1445824
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Built with local dependencies:
    /home/review/rpm_deps/python-nose_fixes-doc-1.3-0.1.fc27.noarch.rpm
    /home/review/rpm_deps/python3-nose_fixes-1.3-0.1.fc27.noarch.rpm
    /home/review/rpm_deps/python2-nose_fixes-1.3-0.1.fc27.noarch.rpm

Comment 2 Björn Esser (besser82) 2017-04-26 16:09:13 UTC

Updated package
---------------


Changelog:

  * Wed Apr 26 2017 Björn Esser <besser82> - 4.13.5-0.2
  - Fix E: python-bytecode-wrong-magic-value

  * Wed Apr 26 2017 Björn Esser <besser82> - 4.13.5-0.1
  - Initial rpm-release (rhbz#1445824)


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures-4.13.5-0.2.fc27.src.rpm

Comment 3 Christian Dersch 2017-04-26 16:16:42 UTC

Approved, issue fixed :)

Comment 4 Gwyn Ciesla 2017-04-27 12:36:58 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-testfixtures

Comment 5 Fedora Update System 2017-04-27 13:20:17 UTC

python-testfixtures-4.13.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

Comment 6 Fedora Update System 2017-04-28 00:23:40 UTC

python-testfixtures-4.13.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

Comment 7 Fedora Update System 2017-05-01 18:16:40 UTC

python-testfixtures-4.13.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 David Hannequin 2017-06-18 16:29:46 UTC

Why 2 bug (Bug 1389346) for 1 package ???

What do you do ?

Comment 9 Björn Esser (besser82) 2017-06-18 21:54:21 UTC

*** Bug 1389346 has been marked as a duplicate of this bug. ***

Comment 10 David Hannequin 2017-06-19 05:48:05 UTC

This package don't work on Fedora 25. And you stole my work... 

Be serious and made this package work.

Comment 11 Björn Esser (besser82) 2017-06-19 07:35:14 UTC

(In reply to David Hannequin from comment #10)
> This package don't work on Fedora 25.

That's because of missing BuildRequires in Fedora <= 25.


> And you stole my work... 

You didn't read the Fedora CLA, huh?  Read it carefully and then I expect you to be sorry…


> Be serious and made this package work.

Is there any guideline around enforcing me to do so?  It seems your parents didn't teach you about politeness…

Comment 12 Fedora Update System 2017-06-19 08:21:25 UTC

python-testfixtures-4.14.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-298c99b698

Comment 13 Fedora Update System 2017-06-19 15:52:48 UTC

python-testfixtures-4.14.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-298c99b698

Comment 14 Fedora Update System 2017-06-25 21:22:20 UTC

python-testfixtures-4.14.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.