Bug 1445915

Summary: jingle_rtp_initiate_media: 'resource' is used after being freed in an error path
Product: [Fedora] Fedora Reporter: Debarshi Ray <debarshir>
Component: pidginAssignee: Debarshi Ray <debarshir>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ignatenko, itamar, jskarvad, jsynacek, stu
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pidgin-2.12.0-2.fc26 pidgin-2.12.0-2.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-15 12:53:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Debarshi Ray 2017-04-26 18:37:50 UTC
Coverity says:

3. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:966: freed_arg:
    "g_free" frees "resource".
5. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:969: pass_freed_arg:
    Passing freed pointer "resource" as an argument to "purple_debug_error".
#   967|   
#   968|   	if (!jbr) {
#   969|-> 		purple_debug_error("jingle-rtp", "Could not find buddy's resource - %s\n", resource);
#   970|   		return FALSE;
#   971|   	}

Patch sent upstream:
https://developer.pidgin.im/ticket/17200

Comment 1 Debarshi Ray 2017-04-26 19:21:30 UTC
I have built pidgin-2.12.0-2 for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19220355

I'll backport it to older branches if the patch looks sane. I don't trust myself with late night fixes. :)

Comment 2 Fedora Update System 2017-05-10 10:36:49 UTC
pidgin-2.12.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba5cdb6af0

Comment 3 Fedora Update System 2017-05-10 12:08:46 UTC
pidgin-2.12.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6fc66d3a07

Comment 4 Fedora Update System 2017-05-12 13:35:42 UTC
pidgin-2.12.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6fc66d3a07

Comment 5 Fedora Update System 2017-05-13 01:09:45 UTC
pidgin-2.12.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba5cdb6af0

Comment 6 Fedora Update System 2017-05-15 12:53:17 UTC
pidgin-2.12.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2017-05-16 21:57:18 UTC
pidgin-2.12.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-05-17 06:02:48 UTC
pidgin-2.12.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.