Bug 1446056

Summary:	[downstream clone - 4.1.2] [TEXT] - engine-upgrade-check should prompt user that while RPMs are updated the engine might not be updated if he didn't run engine setup
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	ovirt-engine	Assignee:	Lev Veyde <lveyde>
Status:	CLOSED ERRATA	QA Contact:	Aleksei Slaikovskii <aslaikov>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.4	CC:	eheftman, jbelka, lsurette, ppostler, pstehlik, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, ykaul, ylavi
Target Milestone:	ovirt-4.1.2	Keywords:	EasyFix, ZStream
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Previously, after running engine-upgrade-check, the user was not informed that the system may not be up-to-date if engine-setup was not run after running yum update, for example. This is despite engine-upgrade-check stating that no upgrade is available. This has now been fixed so that a warning message is displayed to the user if engine-setup was not run.	Story Points:	---
Clone Of:	1324532	Environment:
Last Closed:	2017-05-24 11:23:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1324532
Bug Blocks:

Description rhev-integ 2017-04-27 07:50:00 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1324532 +++
======================================================================

3. What is the nature and description of the request?
RHEV engine-upgrade-check says no updates available when the rhevm-setup package is up to date, but this does not neccessary mean the engine is up to date. One can run yum update on the the system and have the rhevm-setup up to date but still have an outdated rhevm because engine-setup didn't run.
Eg, 

# engine-upgrade-check
VERB: queue package rhevm-setup for update
VERB: Downloading: repomdE9SThbtmp.xml (0%)
VERB: Downloading: repomdE9SThbtmp.xml 2.1 k(100%)
VERB: Downloading: repomdFpcNa_tmp.xml (0%)
VERB: Downloading: repomdFpcNa_tmp.xml 2.1 k(100%)
VERB: Building transaction
VERB: Empty transaction
VERB: Transaction Summary:
No upgrade

4. Why does the customer need this? (List the business requirements here)
The current behaviour is confusing. Engine-upgrade-check says the system is up to date, while it's not.

5. How would the customer like to achieve this? (List the functional requirements here)
Change engine-upgrade-check and make it check all engine rpm's and not just the one for rhevm-setup

6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
run yum update on a system without running engine-setup. Run engine-upgrade-check and check if there's a message like eg "The rhevm-setup is already updated. Please run engine-setup to update the rhev-m as well"

7. Is there already an existing RFE upstream or in Red Hat Bugzilla?
Not aware of any

8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
no

9. Is the sales team involved in this request and do they have any additional input?
no

10. List any affected packages or components.
rhevm*.rpm

11. Would the customer be able to assist in testing this functionality if implemented? 
yes, but I don't think it's difficult to test this at RH. :-)

(Originally by agkesos)

Comment 3 rhev-integ 2017-04-27 07:50:13 UTC

10. List any affected packages or components.
# rpm -qf /usr/bin/engine-upgrade-check
rhevm-setup-plugin-ovirt-engine-3.6.4.1-0.1.el6.noarch

(Originally by agkesos)

Comment 4 rhev-integ 2017-04-27 07:50:18 UTC

dropping [TEXT] since this imply functional changes that need to handle version lock plugin, not only print output.

(Originally by Sandro Bonazzola)

Comment 8 rhev-integ 2017-04-27 07:50:38 UTC

WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[FOUND CLONE FLAGS: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ]

For more info please contact: rhv-devops

(Originally by rhev-integ)

Comment 9 rhev-integ 2017-04-27 07:50:44 UTC

WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[FOUND CLONE FLAGS: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ]

For more info please contact: rhv-devops

(Originally by rhev-integ)

Comment 10 rhev-integ 2017-04-27 07:50:50 UTC

WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[FOUND CLONE FLAGS: ['rhevm-4.1.z', 'rhevm-4.2-ga'], ]

For more info please contact: rhv-devops

(Originally by rhev-integ)

Comment 12 Aleksei Slaikovskii 2017-05-02 07:04:56 UTC

Verified on ovirt-engine-4.1.2-0.1.el7.noarch

# engine-upgrade-check 
VERB: queue package ovirt-engine-setup for update
VERB: Downloading: ...
...
VERB: Building transaction
VERB: Empty transaction
VERB: Transaction Summary:
No upgrade is available for the setup package.
Please note that system may not be up to date if engine-setup wasn't executed after yum update.

Comment 14 errata-xmlrpc 2017-05-24 11:23:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1280