Bug 1446072

Description of problem:

After running update 08 on JBoss ON 3.3.5 server fails to start with the message:

*********************************************
ERROR [org.jboss.as.ejb3] (pool-6-thread-1) JBAS014268: Failure in caller transaction.: java.lang.NullPointerException
at org.rhq.enterprise.server.system.SystemManagerBean.transformSystemConfigurationPropertyFromDb(SystemManagerBean.java:523) [rhq-server.jar:4.12.0.JON330GA-redhat-8]
at org.rhq.enterprise.server.system.SystemManagerBean.fillCache(SystemManagerBean.java:956) [rhq-server.jar:4.12.0.JON330GA-redhat-8]
at org.rhq.enterprise.server.system.SystemManagerBean.loadSystemConfigurationCache(SystemManagerBean.java:482) [rhq-server.jar:4.12.0.JON330GA-redhat-8]
at org.rhq.enterprise.server.system.SystemManagerBean.getCachedObfuscatedSettings(SystemManagerBean.java:927) [rhq-server.jar:4.12.0.JON330GA-redhat-8]
at org.rhq.enterprise.server.system.SystemManagerBean.getObfuscatedSystemSettings(SystemManagerBean.java:252) [rhq-server.jar:4.12.0.JON330GA-redhat-8]
...
*********************************************

Version-Release number of selected component (if applicable):
Upgrade from JBoss ON 3.3.5 to 3.3.8

How reproducible:
Always

Steps to Reproduce:
Red Hat JBoss Operations Network (ON) 3.3.5;
1. Make any change in the System Configuration page in JBoss ON UI by following instructions in the Red Hat knowledge solution: It is not possible to save changes in the system settings of the JBoss ON UI (https://access.redhat.com/solutions/2165051);
2. Apply update 08;
3. Start JBoss ON;


Actual results:
Server fails to start and above error is logged in the server.log file.


Expected results:
No error is logged and server is properly started.

Additional info:

It seems that SystemSetting.getByInternalName(configKey) [1] method returns null for properties PARTITION_EVENT_PURGE and RESOURCE_CONFIG_HISTORY_PURGE. Looking at the SystemSetting.java [2], properties PARTITION_EVENT_PURGE and RESOURCE_CONFIG_HISTORY_PURGE are not found and because of that "null" is returned.


[1] https://github.com/rhq-project/rhq/blob/RHQ_4_12_0_JON338GA/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/system/SystemManagerBean.java#L941
[2] https://github.com/rhq-project/rhq/blob/RHQ_4_12_0_JON338GA/modules//core/domain/src/main/java/org/rhq/core/domain/common/composite/SystemSetting.java