Bug 1446161

Created attachment 1274576 [details]
virt-viewer --debug log

Created attachment 1274577 [details]
screenshot

There are a couple of things to consider here:

1) When in kiosk mode, there should be no toolbar presented to the user so they can leave fullscreen mode.

2) In the case of cancelling the authentication while in kiosk mode, the app should either quit or present the dialog again. I tend to prefer the first option, otherwise there will be complaints about never being able to quit.

Please, mark as regression if bug wasn't present in previous release

Fixed by upstream commits 8ab98eec203e0a113be7509e36d10c8511e186ac and 5d9e6d2338cbb680fe761b86e6ca433b1234e6e0

I verified it with virt-viewer-5.0-5.el7.x86_64.

The leave fullscreen problem has been fixed. 

But another problem, after clicking cancel button, "Authentication failed: wrong password?" dialog pops.
This is not as expected. Can we just close the 'Authentication required' dialog and pops it again and no any failed dialog pops when users cancel it?

There are still other problems about authentication in -k mode.
1. 
Steps:
1). Run "virt-viewer -c qemu:///system $guest -k" to open a running password specified guest, and "Authentication required" dialog pops up.
2). Leave the dialog there and Destroy the guest, "Authentication failed: wrong password" dialog pops up (I think this dialog should not pop up and "Authentication required" dialog should be closed and correct status be displayed in virt-viewer main window).
3). Click ok to close "Authentication failed: wrong password" dialog and leave "Authentication required" dialog there, then start the guest again. A new "Authentication required" dialog pops up and covers the previous one (Now there are two dialogs).
4). Type correct password in the top of the dialog. graphic server can be connected successfully. But the previous "Authentication required" dialog is still there.
5). Following step4, now you two choices. If click 'ok', yes, the dialog can be closed and you can do operation with the guest normally. But if click 'cancel',  "Authentication required" dialog will pop up and "unable to connect to the graphic server xxxx" dialog pops. You lost connection with the graphic server.  and have to restart the guest to reauthentication or restart virt-viewer process to reconnect to the graphic server.

2. Run "virt-viewer -c qemu:///system $guest -k --kiosk-quit on-disconnect" and "Authentication required" dialog pops, then destroy the guest,  virt-viewer cannot quit at once. "Authentication failed: wrong password?" dialog pops first. If close the authentication failed dialog, "Authentication required" dialog is still there. virt-viewer can quit after clicking 'cancel' or 'ok'.

I think 1&2 are same problems and need virt-viewer to do more changes to fix them. i can file another bug to trace the problem.


3. Run "remote-viewer spice://localhost:5900 -k" to connect to guest, then shutdown the guest, start up the guest again. remote-viewer cannot reconnect to the graphic server (The listen port doesn't change during testing).

I think this is a new problem, i'll file a new bug.

(In reply to xiaodwan from comment #9)
> I verified it with virt-viewer-5.0-5.el7.x86_64.
> 
> The leave fullscreen problem has been fixed. 
> 
> But another problem, after clicking cancel button, "Authentication failed:
> wrong password?" dialog pops.
> This is not as expected. Can we just close the 'Authentication required'
> dialog and pops it again and no any failed dialog pops when users cancel it?

Yes, you are right.
I think it is best to failedQA and we do a new build with an extra patch to work around the error.

(In reply to xiaodwan from comment #10)
> I think 1&2 are same problems and need virt-viewer to do more changes to fix
> them. i can file another bug to trace the problem.

Yes, please. Please do check for regression in those behaviors too.

> 3. Run "remote-viewer spice://localhost:5900 -k" to connect to guest, then
> shutdown the guest, start up the guest again. remote-viewer cannot reconnect
> to the graphic server (The listen port doesn't change during testing).
> 
> I think this is a new problem, i'll file a new bug.

Thanks again

Sent a patch to work around the dialog error
https://www.redhat.com/archives/virt-tools-list/2017-June/msg00009.html

Patch merged upstream 6480e52f62bc7c87bbdca1aa50f7ff08b09e9845, will be included in 5.0-6 build.

(In reply to Eduardo Lima (Etrunko) from comment #13)
> Patch merged upstream 6480e52f62bc7c87bbdca1aa50f7ff08b09e9845, will be
> included in 5.0-6 build.

This patch doesn't fix the issue for vnc server.

(In reply to xiaodwan from comment #15)
> (In reply to Eduardo Lima (Etrunko) from comment #13)
> > Patch merged upstream 6480e52f62bc7c87bbdca1aa50f7ff08b09e9845, will be
> > included in 5.0-6 build.
> 
> This patch doesn't fix the issue for vnc server.

This is the first time you have mentioned vnc in this bug.
You mean the kiosk mode in fullscreen, described in comment #0 but for vnc? Or do you mean the error dialog? I'll be checking this shortly as well.

> This is the first time you have mentioned vnc in this bug.
> You mean the kiosk mode in fullscreen, described in comment #0 but for vnc?
> Or do you mean the error dialog? I'll be checking this shortly as well.

I mean when connecting to a vnc server, after cancel the authentication, the error dialog also displays. 

And above patch only fixes spice.

I thought you know. In the previous patch series, you modified both spice and vnc.
:)

(In reply to xiaodwan from comment #17)
> I thought you know. In the previous patch series, you modified both spice
> and vnc.

The patch that changed vnc was a preparatory patch, it would still show this error. But don't worry about it.

A proposal patch was sent to fix vnc behavior, that is:
https://www.redhat.com/archives/virt-tools-list/2017-June/msg00024.html

I'm doing a scratch build too, feel free to test in the meanwhile.
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13351751

I tested the scratch build.

After authentication dialog pops for vnc server, then click ok with blank password, the dialog will be closed and will not pop up again. And the virt-viewer cannot be closed normally except kill the process.

Thanks for testing. I missed that.

V2 is:
https://www.redhat.com/archives/virt-tools-list/2017-June/msg00025.html

scratch-build is:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13353651

(In reply to Victor Toso from comment #20)
> Thanks for testing. I missed that.
> 
> V2 is:
> https://www.redhat.com/archives/virt-tools-list/2017-June/msg00025.html
> 
> scratch-build is:
> https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13353651

I verified this build.
virt-viewer work well for spice and vnc.


and I also tried a missed scenario of "remote-viewer --ovirt-ca-file=xxx ovirt://xxx/xxx -k", when clicking cancel button, remote-viewer quit directly.

Do you think this should be fixed, too? If you don't have enough time for rhel7.4, i can file a new bug to rhel7.5.

Thanks and sorry for the missed scenario when i verified it.

> > scratch-build is:
> > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13353651
> 
> I verified this build.
> virt-viewer work well for spice and vnc.

Thank you for testing.

> and I also tried a missed scenario of "remote-viewer --ovirt-ca-file=xxx
> ovirt://xxx/xxx -k", when clicking cancel button, remote-viewer quit
> directly.
> 
> Do you think this should be fixed, too? If you don't have enough time for
> rhel7.4, i can file a new bug to rhel7.5.

That would mean that kiosk mode is not being handled correctly. Yes, I think this need to be fixed but definitely not in 7.4

> Thanks and sorry for the missed scenario when i verified it.

No worries, good job.

(In reply to Victor Toso from comment #23)
> > > scratch-build is:
> > > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13353651
> > 
> > I verified this build.
> > virt-viewer work well for spice and vnc.
> 
> Thank you for testing.
> 
> > and I also tried a missed scenario of "remote-viewer --ovirt-ca-file=xxx
> > ovirt://xxx/xxx -k", when clicking cancel button, remote-viewer quit
> > directly.
> > 
> > Do you think this should be fixed, too? If you don't have enough time for
> > rhel7.4, i can file a new bug to rhel7.5.
> 
> That would mean that kiosk mode is not being handled correctly. Yes, I think
> this need to be fixed but definitely not in 7.4
> 
> > Thanks and sorry for the missed scenario when i verified it.
> 
> No worries, good job.

So there is a new virt-viewer build including the above fix with both spice and vnc guest,and all left issues can be tracked by a new bug,am I right?

If so,pls build the new package as soon as possible,we will do some testing for that and use the new build to do regression testing,thanks.

> If so,pls build the new package as soon as possible,we will do some testing
> for that and use the new build to do regression testing,thanks.

Sure, I'll be doing a build in the next half hour or so.

I verified it with virt-viewer-5.0-7.el7.x86_64 and tried both spicea and vnc.

All work well.

so move the bug to VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1849