Bug 1446395
| Summary: | Rawhide installer images fail to boot since tmux 2.4 landed | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | tmux | Assignee: | Sven Lankes <sven> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | awilliam, dcantrell, kevin, mkolman, praiskup, rosset.filipe, sbueno, strobert, sven, tomek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-10 07:04:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Williamson
2017-04-27 19:56:51 UTC
Hi guys, I'm not familiarized with anaconda vs. tmux settings, can you please take a look if this is broken due some changes on 2.4 release? https://raw.githubusercontent.com/tmux/tmux/master/CHANGES Well it obviously *is* caused by some change in the 2.4 release, that's the whole point of the bug report. :) But none of the changes described in that log look to be related, to me. I usually find it more useful to read the raw commit log. According to the CHANGES-File the option set-remain-on-exit no longer exists in 2.4:
> * set-remain-on-exit has gone -- can be achieved with hooks instead.
https://github.com/tmux/tmux/issues/787 According to his: set-hook -g session-created 'set remain-on-exit on' should fix it. I haven't tested it. Anaconda anaconda-27.5-1, which was released yesterday, should have a fix[0] for this. [0] https://github.com/rhinstaller/anaconda/pull/1042 anaconda-26.21.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f620d8c7c2 Sven: you did read the part of the report where I saw that message, tried taking the option out of the config file, and it still didn't start up, right? "I did try removing the 'set-remain-on-exit' option from the config file and restarting the service; that makes the 'invalid option' line go away, but anaconda still fails to start, so I don't *think* that's the problem." Martin: thanks for the changes. Did you check they're safe on tmux 2.3 as well, though? tmux 2.4 was not built for F26, F26 is still on 2.3. So this doesn't work properly, for two reasons. One, bc isn't in the installer environment. Two, it's not *right*. bc does a floating point number comparison, not a version comparison (given the conventions of how software is normally versioned). For instance, that means it thinks 1.9 > 1.10 (because as a number, it *is*). This: https://stackoverflow.com/questions/4023830/how-compare-two-strings-in-dot-separated-version-format-in-bash suggests using sort -V to do a version sort, which seems like a reasonable solution. I'll send a modified PR and test it. I believe https://github.com/rhinstaller/anaconda/pull/1048 should fix this properly. I'm also editing the F26 update and removing the link to this bug; it doesn't make sense because this bug didn't really affect F26, tmux 2.4 wasn't sent to F26. So there's reason to make the push of that update close this bug. If the original fix had worked, we could close the bug already; since it didn't, we can close it whenever a working fix is pushed to Rawhide and lands in a compose. can we close this one? also tmux-2.5 will land on rawhide shortly: https://koji.fedoraproject.org/koji/taskinfo?taskID=19942642 Sure, it was merged a while back and seems to be working fine. |