Bug 1446412

Summary:	error-gen don't need to convert error string to int in every fop
Product:	[Community] GlusterFS	Reporter:	Zhou Zhengping <johnzzpcrystal>
Component:	error-gen	Assignee:	Zhou Zhengping <johnzzpcrystal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-05 17:27:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zhou Zhengping 2017-04-27 22:17:30 UTC

Description of problem:

Every fop in xlator error-gen will call function error_gen, which will call function conv_error to convert pvt->error_no to int. But actually the function 
only need to be called in init and reconfigure

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-04-27 22:17:54 UTC

REVIEW: https://review.gluster.org/17132 (debug/error-gen: Don't need to convert error string to int in every fop) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 2 Worker Ant 2017-05-04 00:57:59 UTC

REVIEW: https://review.gluster.org/17132 (debug/error-gen: Don't need to convert error string to int in every fop) posted (#2) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 3 Worker Ant 2017-05-08 13:15:20 UTC

COMMIT: https://review.gluster.org/17132 committed in master by Jeff Darcy (jeff.us) 
------
commit 68b4db2ac37af3283580b74eef5d405c9370b0c0
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Fri Apr 28 06:12:56 2017 +0800

    debug/error-gen: Don't need to convert error string to int in every fop
    
    Every fop in xlator error-gen will call function error_gen,
    which will call function conv_error to convert pvt->error_no to int.
    But actually the function could only be called in init and reconfigure
    
    Change-Id: I96c9780574f369fc58eed10fea9d50c4cd7d4e8a
    BUG: 1446412
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: https://review.gluster.org/17132
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 4 Shyamsundar 2017-09-05 17:27:45 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/