Bug 1446683

Description of problem:
/usr/bin/katello-backup will produce full backups instead of incremental backups, even when the --incremental option is used.

The fix exists upstream, but we need it now for Satellite 6.2 as multiple customers are probably hitting the issue.


The consequence of this issue is that supposedly incremental backups (i) are not incremental but full and (ii) consume at least as much storage space as the full backup they point to.

The root cause is the underlying shell's globbing behavior and is fixed by the upstream commit at https://github.com/Katello/katello-packaging/commit/77bc87f20f74c3bb705ba2f118fb174aa2580b79

katello-backup attempts to copy the .something.snar files from the previous backup with a `cp /src/*.snar /dest/` which fails because the shell does not by default match *.snar to .something.snar.

The fix modifies shell globbing behavior with `shopt -s dotglobbing ; cp /src/*.snar /dest/` but it can also be solved by adding a dot to the command: `cp /src/.*.snar /dest/`.



Version-Release number of selected component (if applicable):
Satellite 6.2.8, possibly earlier versions as well.
katello-common-3.0.0-17.el7sat.noarch


How reproducible:
Always

Steps to Reproduce:
1. On Satellite 6.2.8 run katello-backup /full/backup/dir --skip-pulp-content

2. After full backup completes, run katello-backup /first/incremental/backup --skip-pulp-content --incremental /full/backup/dir

3. Check backup sizes by running du -sh /full/backup/dir /first/incremental/backup



Actual results:
Backup sizes will roughly be the same.

Expected results:
An incremental backup taken mere minutes after the latest full backup should be significantly smaller than the full backup.


Additional info:

On a test Satellite 6.2.8 with ~5 repos synced, these are the results after multiple runs of katello-backup within a 2 hour period:

# du -sh /satbackup/*

14G     /satbackup/katello-backup-2017-04-25T10:40:32-03:00
14G     /satbackup/katello-backup-2017-04-25T11:05:22-03:00
1.8G    /satbackup/katello-backup-2017-04-25T12:24:03-03:00

First line is the full backup.
Second line is the incremental backup pointed at the first one.
Third line is a new incremental backup pointed at the full backup *after applying the fix*.


Can we have a fix for Satellite 6.2?