Bug 1446934

Charalampos updated pybox2d so I suspect something has happened on the move to 2.3.2

Here is the traceback from Fedora Spin SoaS 26 packaged with Physics 32.1:

Traceback (most recent call last):
  File "/usr/bin/sugar-activity", line 220, in <module>
    main()
  File "/usr/bin/sugar-activity", line 164, in main
    module = __import__(module_name)
  File "/usr/share/sugar/activities/Physics.activity/activity.py", line 62, in <module>
    import tools
  File "/usr/share/sugar/activities/Physics.activity/tools.py", line 35, in <module>
    import lib.Box2D as box2d
ImportError: No module named lib.Box2D
Exited with status 1, pid 1951 data (<open file '<fdopen>', mode 'w' at 0x7f3c9451cdb0>, 'aee31508626e498542ffca08474e032c0d530bf0')

Apologies for not getting to it sooner, there is way too much stuff on my backlog. I might be able to get to it, in hopefully two weeks time.

The issue here is not related to pybox2d rebase but to the way that sugar-physics handles the box2d import.

More specifically, sugar-physics bundles Box2D [0], adds the directory to the path and then imports it from that directory.

This started happening since v30 of physics  for elements.py and physics.py [1] and v32 for tools.py where the failure was noticed [2].

The fedora package of sugar-physics though, removes that directory so that import is not valid anymore. In order to use the system package the import has to be changed back:

-import lib.Box2D as box2d
+import Box2D as box2d

However I am unclear on how this might affect Physics as a bundle, if at all. A small discussion about it at [3].

Also I tried to get the traceback on Fedora SoaS spin but I wasn't able to capture it, however when I changed the code inside a running spin, I was able to start physics normally.

[0] https://github.com/sugarlabs/physics/tree/master/lib
[1] https://github.com/sugarlabs/physics/commit/fdee879283f7ad6a43b7795275b121a002d8465c
[2] https://github.com/sugarlabs/physics/commit/820479f327875e0f06becaa791a7e1ce59e93d11
[3] https://bugs.sugarlabs.org/ticket/4976

Also it seems that even by doing that, the version of Box2D that is bundled with pybox2d will be used by sugar physics, as pybox2d places it in usr/lib64/python2.7/site-packages.

That should be resolved with the resolution of bug 844091.

Sent a PR at https://src.fedoraproject.org/rpms/sugar-physics/pull-request/1

sugar-physics-32.1-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8642981c6b

sugar-physics-32.1-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8642981c6b

Proposed as a Freeze Exception for 27-final by Fedora user pbrobinson using the blocker tracking app because:

 Fixes the Physics app which currently crashes.

Discussed at 2017-11-01 to 2017-11-02 Fedora 27 Go/No-Go meeting, acting as a freeze exception review meeting: https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2017-11-02/f27-final-and-server-beta-go-no-go-meeting.2017-11-02-17.00.html . Accepted as a freeze exception: this would be a blocking issue on a release-blocking desktop spin (included app does not work), which creates a strong presumption in favour of FE status. The fix is clearly limited - it cannot affect anything outside of Sugar. Thus it seems clearly desirable to pull it in and fix the app for the Sugar live image.

sugar-physics-32.1-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.