Bug 1447555

Summary:	view-only accepts enter, unclear whether default password is generated or not
Product:	Red Hat Enterprise Linux 7	Reporter:	Jiri Prajzner <jprajzne>
Component:	tigervnc	Assignee:	Jan Grulich <jgrulich>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.4	CC:	jkoten
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-10 11:37:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1479818

Description Jiri Prajzner 2017-05-03 08:01:58 UTC

Description of problem:
when creating a vnc session, one is asked "Would you like to enter a view-only password (y/n)?". it's possible to respond with "enter" key (or possibly any other key). this is not ideal, as the input doesn't seem to be sanitized and it's not clear whether a password was generated and if yes, what such default password is.

Version-Release number of selected component (if applicable):
1.7.90-2

How reproducible:
always

Steps to Reproduce:
1. vncserver
2. Would you like to enter a view-only password (y/n)? l <enter>
3.

Actual results:
arbitrary input is accepted

Expected results:
only "y" or "n" is accepted

Additional info:
it really should sanitize the input

Comment 2 Jan Grulich 2017-05-03 08:05:53 UTC

Can be easily fixed, but I would leave it for rhel-7.5 as this is not a critical issue.

Comment 3 Jan Grulich 2017-09-12 08:35:56 UTC

It's not possible to accept only certain characters, but I added addional information that view-only password will not be used if you don't type "y|Y".

This will be fixed in tigervnc-1.8.0-2.el7.

Comment 7 errata-xmlrpc 2018-04-10 11:37:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0722