Bug 1447560

Summary: ISO domain images are not displayed
Product: Red Hat CloudForms Management Engine Reporter: Ilanit Stein <istein>
Component: ProvidersAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: Angelina Vasileva <anikifor>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, jfrey, jhardy, masayag, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: rhev, iso datastore
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1460736 (view as bug list) Environment:
Last Closed: 2018-03-06 15:33:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: RHEVM Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1460736    

Description Ilanit Stein 2017-05-03 08:10:11 UTC
Description of problem:

ISO domain images are not displayed on CFME-5.8.0.12, CFME-5.7.2/RHV-4.0.7, RHV-4.1.1.8.

This blocks VM provision from ISO.

On CFME-5.7.0.17 - Some ISO images are displayed, but these are not the images of the only iso domain connected to a RHV datacenter, as it expected to be. 
The ISO images displayed belong to some other ISO domain, that probably was connected sometime in the past. 

Version-Release number of selected component (if applicable):
CFME-5.8.0.12, CFME-5.7.2
RHV-4.0.7, RHV-4.1.1.8
CFME-5.7.0.17

How reproducible:
very

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Not sure if this is a regression or if this is not always working.
 
VM provision from ISO was last tested as part of bug 1414893, as follows:
CFME-5.7.1.3 & RHV-4.0.7
Tested via REST API:
VM provision from: Native/PXE/ISO
- From template with 1 disk, and added 2 disks. 
- From template with no disk, and added 1 disk.

Comment 2 Oved Ourfali 2017-05-04 04:58:10 UTC
As discussed offline, this was caused by having an inactive iso domain, and can be solved by removing that domain. 
Reducing severity,removing blocker flag, and targeting to 5.8.1.

Comment 5 CFME Bot 2017-05-18 11:13:55 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/master:
https://github.com/ManageIQ/manageiq-providers-ovirt/commit/bf2bdd2552f90f1da6f6d96528ef5be04bef7a9c

commit bf2bdd2552f90f1da6f6d96528ef5be04bef7a9c
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Wed May 10 17:44:16 2017 +0300
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Wed May 17 10:36:50 2017 +0300

    Fix fetching ISO images from non active domains
    
    We used to ignore the data-center level when looking for an ISO domain,
    as a result we would sometimes take an ISO domain which was not attached to
    an active data-center.
    We now first find a data-center which is "up" and then take an ISO domain which is
    attached to it and is active.
    This fix is applied for providers that support version 4 of the api.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447560

 .../redhat/infra_manager/api_integration.rb        |  4 +-
 .../infra_manager/ovirt_services/strategies/v3.rb  | 10 +++
 .../infra_manager/ovirt_services/strategies/v4.rb  | 22 +++++++
 .../ovirt_services/strategies/v4_spec.rb           | 73 ++++++++++++++++++++++
 4 files changed, 107 insertions(+), 2 deletions(-)
 create mode 100644 spec/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4_spec.rb

Comment 6 CFME Bot 2017-05-23 12:16:17 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d2856f1f27c0a7495e7db35c66f04e5da6d311bb

commit d2856f1f27c0a7495e7db35c66f04e5da6d311bb
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Wed May 10 17:41:20 2017 +0300
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Mon May 15 08:16:37 2017 +0300

    Fix fetching ISO images from non active domains
    
    We used to take the first available ISO domain even if it was not active.
    As a result we would sometimes miss available ISO images.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447560

 app/models/iso_datastore.rb       | 11 ++---------
 spec/models/iso_datastore_spec.rb | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 9 deletions(-)
 create mode 100644 spec/models/iso_datastore_spec.rb

Comment 11 Ilanit Stein 2017-07-18 08:58:09 UTC
*** Bug 1427475 has been marked as a duplicate of this bug. ***

Comment 12 Ilanit Stein 2017-11-17 04:11:24 UTC
Verified on CFME-5.9.0.8/RHV-4.1.3

Connected from CFME to a RHV that have 2 ISO domains (1 active, 1 inactive)
Compute->PXE->Add new ISO data store - Collects the active one.

Then, remove this ISO datastore.

Switched on RHV side, the ISO domains active<-> inactive
Compute->PXE->Add new ISO data store - Collects the recent active one.