Bug 1447609

Summary:	server: fd should be refed before put into fdtable
Product:	[Community] GlusterFS	Reporter:	Zhou Zhengping <johnzzpcrystal>
Component:	protocol	Assignee:	Zhou Zhengping <johnzzpcrystal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-05 17:28:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zhou Zhengping 2017-05-03 10:11:19 UTC

Description of problem:
  If a network error occurs after we put a fd to fdtable,
 fds in fdtable will be cleaned up by do_fd_cleanup which will
 unref the fd and release the fd if the fd hasn't be refed by user

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-05-03 10:20:23 UTC

REVIEW: https://review.gluster.org/17158 (server: fd should be refed before put into fdtable) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 2 Worker Ant 2017-05-03 16:30:49 UTC

COMMIT: https://review.gluster.org/17158 committed in master by Jeff Darcy (jeff.us) 
------
commit 7178c299d727e98370835ba3dde41f91f087e724
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Wed May 3 17:51:57 2017 +0800

    server: fd should be refed before put into fdtable
    
    	If a network error occurs after we put a fd to fdtable,
    fds in fdtable will be cleaned up by do_fd_cleanup which will
    unref the fd and release the fd if the fd hasn't be refed by user.
    
    Change-Id: Idbad0fafd005c59398518190845fe137cbf95c60
    BUG: 1447609
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: https://review.gluster.org/17158
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Milind Changire <mchangir>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 3 Shyamsundar 2017-09-05 17:28:29 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/