Bug 1447625

Summary:	retirement runs in any zone as of 5.7.1
Product:	Red Hat CloudForms Management Engine	Reporter:	Felix Dewaleyne <fdewaley>
Component:	Control	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Alex Newman <anewman>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.7.0	CC:	cpelland, fdewaley, gblomqui, gmccullo, jfrey, jhardy, jocarter, obarenbo, simaishi, vaclav.miller
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.9.0
Hardware:	All
OS:	All
Whiteboard:	retirement:zone
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1449748 1449753 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:23:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1449748, 1449753

Description Felix Dewaleyne 2017-05-03 10:59:55 UTC

Description of problem:
in Cloudforms 5.7.1

Version-Release number of selected component (if applicable):
5.7.1

How reproducible:
all the time

Steps to Reproduce:
1.deploy openstack 
2.deploy cloudforms (several appliances)
3.put openstack in one cloudforms zone
4. only the appliances in the same zone as the openstack environment should be able to connect to openstack. This can be done with firewall rules or network limitations
5. provision a service against openstack
6. retire that service

Actual results:
the retirement can fail as it runs on a node with autoamtion turned on that isn't in the openstack zone

Expected results:
retirement only runs in the openstack zone

Additional info:
the custome is going to have to  deploy another openstack environment soon and will have to rely heavily on zoning in the same region. 
the retirement is done with the stock method.
the customer is likely to request a hotfix.

Comment 3 CFME Bot 2017-05-08 19:14:06 UTC

https://github.com/ManageIQ/manageiq-automation_engine/pull/18

Comment 4 CFME Bot 2017-05-08 19:41:42 UTC

https://github.com/ManageIQ/manageiq/pull/15026

Comment 5 CFME Bot 2017-05-10 14:25:07 UTC

New commit detected on ManageIQ/manageiq-automation_engine/master:
https://github.com/ManageIQ/manageiq-automation_engine/commit/c3cf50f30a3ccfe21e8fce71269f79dd41b7eb34

commit c3cf50f30a3ccfe21e8fce71269f79dd41b7eb34
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Fri May 5 16:33:45 2017 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed May 10 09:49:48 2017 -0400

    Add zone to q_options in call_automate.
    
    Separate Manageiq change to pass zone_name required.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447625

 lib/miq_automation_engine/engine/miq_ae_event.rb |  1 +
 spec/miq_ae_event_spec.rb                        | 55 +++++++++++++++++++++---
 2 files changed, 49 insertions(+), 7 deletions(-)

Comment 6 CFME Bot 2017-05-10 14:46:19 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/7239d705579819f5c574046a9e4fc38495acc522

commit 7239d705579819f5c574046a9e4fc38495acc522
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Fri May 5 16:26:21 2017 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Tue May 9 18:28:06 2017 -0400

    Change raise_retirement_event to pass zone.
    
    Separate Automate engine miq_ae_event change required.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447625

 app/models/mixins/retirement_mixin.rb                        | 10 +++++++++-
 .../models/orchestration_stack/retirement_management_spec.rb |  7 ++++---
 spec/models/service/retirement_management_spec.rb            |  6 +++---
 spec/models/vm/retirement_management_spec.rb                 | 12 ++++++++----
 4 files changed, 24 insertions(+), 11 deletions(-)