Bug 1447701

Summary: Retirement tab is not shown for retired service
Product: Red Hat CloudForms Management Engine Reporter: Dmitry Misharov <dmisharo>
Component: AutomateAssignee: Bill Wei <bilwei>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, dajohnso, dmisharo, gmccullo, jhardy, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: ui:ansible:service:retirement
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1448868 (view as bug list) Environment:
Last Closed: 2018-03-06 15:44:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1506796    
Bug Blocks: 1448868    

Description Dmitry Misharov 2017-05-03 14:17:22 UTC
Description of problem:
Retirement tab is not shown for retired service if the retirement tab in original catalog item was filled after its creation.

Version-Release number of selected component (if applicable):
5.8.0.13-rc2.20170502165848_0f98658 

How reproducible:
Always

Steps to Reproduce:
1. Enable Embedded Ansible role.
2. Wait until it will be enabled.
3. Navigate to Automation/Ansible.
4. Add some credential and repository with ansible playbook.
5. Navigate to Services/Catalogs/Catalog Items.
6. Create a catalog item, don't fill retirement tab.
7. Edit just created catalog item, fill retirement tab.
8. Provision a service from the catalog item.
9. Perform service retirement.

Actual results:
Retirement tab is missing.

Expected results:
Retirement tab should be shown.

Comment 2 Tina Fitzgerald 2017-05-03 14:32:40 UTC
Hi Dmitry,

Can I access your environment?

Thanks,
Tina

Comment 4 Tina Fitzgerald 2017-05-03 15:19:01 UTC
The issue here is that retirement instance doesn't reflect the updated retirement information.

----] I, [2017-05-03T10:49:03.849637 #2947:f15130]  INFO -- : Following Relationship [miqaedb:/Service/Generic/StateMachines/GenericLifecycle/Retire_Basic_Resource?update_status> Status message: Server [EVM1] Service [Retirement filled later] Retirement Step [start] Status [Processing StartRetirement]
[----] I, [2017-05-03T10:49:04.860921 #2947:f047b8]  INFO -- : <AEMethod update_status> Ending update_status

The instance name should start with Retired_Advanced.

Comment 6 CFME Bot 2017-05-08 13:01:19 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ceefbbe4551beec920d755480cdcfd9372dbecf3

commit ceefbbe4551beec920d755480cdcfd9372dbecf3
Author:     Bill Wei <bilwei>
AuthorDate: Thu May 4 16:06:23 2017 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Thu May 4 16:06:23 2017 -0400

    config_info should not contain key :configuration_template
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447701

 app/models/service_template_ansible_playbook.rb       | 11 +++++++++++
 spec/models/service_template_ansible_playbook_spec.rb |  1 +
 2 files changed, 12 insertions(+)

Comment 7 CFME Bot 2017-05-08 13:01:25 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/dcece3e929ddfd502b76172b0321513ffe72d7d9

commit dcece3e929ddfd502b76172b0321513ffe72d7d9
Author:     Bill Wei <bilwei>
AuthorDate: Thu May 4 15:32:09 2017 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Thu May 4 15:32:09 2017 -0400

    Add :fqname to list of updatable attributes
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447701

 app/models/service_template.rb       | 1 +
 spec/models/service_template_spec.rb | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

Comment 8 CFME Bot 2017-05-08 13:01:31 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c5f755e67928aec15985217b22861882c6a5d2b5

commit c5f755e67928aec15985217b22861882c6a5d2b5
Author:     Bill Wei <bilwei>
AuthorDate: Thu May 4 16:51:10 2017 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Thu May 4 16:51:10 2017 -0400

    #create_dialogs used by both create and update_catalog_item
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447701

 app/models/service_template_ansible_playbook.rb | 33 +++++++++++--------------
 1 file changed, 14 insertions(+), 19 deletions(-)

Comment 9 CFME Bot 2017-05-08 13:01:37 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2dc391f7bbcd92e28a0e8d68217c88713df3ce32

commit 2dc391f7bbcd92e28a0e8d68217c88713df3ce32
Author:     Bill Wei <bilwei>
AuthorDate: Fri May 5 14:27:15 2017 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Fri May 5 17:36:14 2017 -0400

    Update resource_action immediately after job template is deleted
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447701

 app/models/service_template_ansible_playbook.rb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comment 11 Dmitry Misharov 2017-11-03 08:55:58 UTC
Fixed and verified in 5.9.0.5.20171102023815_209f732.