Bug 1447998

Summary:	Warning message of BC deletion on web is inconsistent with the result
Product:	OpenShift Container Platform	Reporter:	Xingxing Xia <xxia>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	XiaochuanWang <xiaocwan>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.0	CC:	aos-bugs, jokerman, mburke, mmccomas, smunilla
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-21 13:00:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xingxing Xia 2017-05-04 11:22:07 UTC

Description of problem:
When deleting BC on web, it warns:"Note: None of the builds created by this build config will be deleted. To delete the build config and all of its builds, you can run the command."
But after confirming the BC delete, its builds are deleted.The warning is inconsistent with the result. OCP 3.5 has no the problem

DC and its rc have no the problem

Version-Release number of selected component (if applicable):
openshift v3.6.63

How reproducible:
Always

Steps to Reproduce:
1. Create project and BC that would trigger build
2. After build finished, on web console BC page, Actions --> Delete the BC
3. Check the build

Actual results:
2. It warns:
Note: None of the builds created by this build config will be deleted. To delete the build config and all of its builds, you can run the command.

3. The build is deleted in fact

Expected results:
3. The warning and the result should be consistent.

Additional info:

Comment 1 Jessica Forrester 2017-05-04 12:58:48 UTC

It was expected for this to happen once garbage collection was turned on, please see the card https://trello.com/c/mt9c2Nxx we'll be fixing this issue there.

Comment 2 Jessica Forrester 2017-05-10 14:17:53 UTC

Warnings for build delete are removed in https://github.com/openshift/origin-web-console/pull/1530

Builds actually should not have been getting garbage collected yet since the console was not sending delete options to tell the delete to cascade.  There is a separate issue tracking that https://github.com/openshift/origin/issues/14120

We have updated deletes to default to cascade in the origin-web-common source, we still need to cut a release of that and merge it into the console to pick up that change.

Comment 3 Samuel Padgett 2017-05-10 18:55:13 UTC

Fix to remove the incorrect warning:

https://github.com/openshift/origin-web-console/pull/1530

Fix to always cascade on delete:

https://github.com/openshift/origin-web-common/pull/64
https://github.com/openshift/origin-web-console/pull/1534

Comment 5 XiaochuanWang 2017-06-05 09:53:32 UTC

Verified on openshift/oc v3.6.94
Warning message is updated to
"""
Are you sure you want to delete the build config 'ruby-sample-build'?

This will delete the build config and all build history. It cannot be undone. Make sure this is something you really want to do!
"""

All builds will be deleted together when BC is deleted.