Bug 1448023
| Summary: | CFME reports VM migration passed when it fails on RHV side | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | movciari | |
| Component: | Providers | Assignee: | Piotr Kliczewski <pkliczew> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Angelina Vasileva <anikifor> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.8.0 | CC: | cpelland, jfrey, jhardy, mgoldboi, obarenbo, simaishi, tjelinek, wfitzger | |
| Target Milestone: | GA | Keywords: | TestOnly | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | vm:migrate:rhev | |||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1478518 1533280 (view as bug list) | Environment: | ||
| Last Closed: | 2018-06-21 20:47:21 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | RHEVM | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1478518, 1533280 | |||
|
Description
movciari
2017-05-04 12:07:40 UTC
Tomas, can you please take a look? The reason is that the the migration is only called and there is no monitoring of the task. So it returns as migration succeeded if the call succeeded and fail if it fails. This actually handles most of the cases since the migration typically fails on validation right at the beginning (e.g. the VM can not be migrated for some reason). The less common case that the migration is initiated successfully but during running it fails is not handled. Will have a look how hard would it be to introduce the monitoring of the migration. William - will that get into 5.8.1? Oved - I added a fine/yes label to the PR so it should be backported to 5.8.1 New commit detected on ManageIQ/manageiq-content/master: https://github.com/ManageIQ/manageiq-content/commit/77b0ba7edc745324eca9507bb2cdd6764921a9cf commit 77b0ba7edc745324eca9507bb2cdd6764921a9cf Author: william fitzgerald <wfitzger> AuthorDate: Fri Jun 23 12:24:39 2017 -0400 Commit: william fitzgerald <wfitzger> CommitDate: Fri Jun 23 14:11:06 2017 -0400 Updated vm migration to report when an error occurs. Updated checkmigration method to raise an error. Refactored method to new style and create new spec tests. https://bugzilla.redhat.com/show_bug.cgi?id=1448023 .../Methods.class/__methods__/checkmigration.rb | 68 ++++++++++++----- .../__methods__/checkmigration_spec.rb | 88 ++++++++++++++++++++++ 2 files changed, 139 insertions(+), 17 deletions(-) create mode 100644 spec/content/automate/ManageIQ/Infrastructure/VM/Migrate/StateMachines/Methods.class/__methods__/checkmigration_spec.rb ok, thanks New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/377f42225ef7a50a2ed00af6a4e6097b4c3742bf commit 377f42225ef7a50a2ed00af6a4e6097b4c3742bf Author: Bill Wei <bilwei> AuthorDate: Wed Dec 20 15:43:32 2017 -0500 Commit: Bill Wei <bilwei> CommitDate: Thu Dec 21 09:03:45 2017 -0500 Rescue migration error and update status https://bugzilla.redhat.com/show_bug.cgi?id=1448023 app/models/vm_migrate_task.rb | 14 ++++++++++---- spec/models/vm_migrate_task_spec.rb | 18 ++++++++++++++++++ 2 files changed, 28 insertions(+), 4 deletions(-) create mode 100644 spec/models/vm_migrate_task_spec.rb New commit detected on ManageIQ/manageiq-providers-ovirt/master: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/a27a3a15d2045db45ed99f4bc82aaf0fabc5c41d commit a27a3a15d2045db45ed99f4bc82aaf0fabc5c41d Author: Piotr Kliczewski <piotr.kliczewski> AuthorDate: Fri Dec 22 13:29:21 2017 +0100 Commit: Piotr Kliczewski <piotr.kliczewski> CommitDate: Wed Jan 10 13:37:18 2018 +0100 Block migration call We need to align migration call semantic with vmware. We want to block the call and return with success or raise an error. Fixes https://bugzilla.redhat.com/1448023 .../manageiq/providers/redhat/infra_manager.rb | 18 +++++++++++++- .../providers/redhat/infra_manager_spec.rb | 29 ++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) |