Bug 1448274

Summary: Unable to add multiple elements to a dialog
Product: Red Hat CloudForms Management Engine Reporter: Shveta <sshveta>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: cpelland, dajohnso, hkataria, jhardy, mpovolny, obarenbo, simaishi, sshveta
Target Milestone: GAKeywords: Regression, TestOnly
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: service:dialog
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1448943 (view as bug list) Environment:
Last Closed: 2018-03-06 15:13:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1448943    
Attachments:
Description Flags
validation message none

Description Shveta 2017-05-05 04:12:17 UTC
Created attachment 1276485 [details]
validation message

Description of problem:Unable to add more than one element to a new dialog


Version-Release number of selected component (if applicable):
5.8.0.13-rc2-nightly.20170504223201_4cd3f14 

How reproducible:


Steps to Reproduce:
1. Create a new dialog (Automate - Customization - Service Dialog)
2. Add a new tab and box to the dialog , add one element.
3. After adding one element , click on (+) plus button at the top to add new element . 
4. Validation message is shown . See screenshot 

Actual results:


Expected results:


Additional info:

Comment 2 Dave Johnson 2017-05-05 13:50:06 UTC
Shveta, any idea when we last saw this working?  Is it a regression that was working a build or two ago?  Was it working in 5.7.z?

Setting tentative blocker...

Comment 4 Shveta 2017-05-05 17:37:18 UTC
Works fine in 5.7 .
Can be checked at https://10.16.6.103.

Comment 5 Harpreet Kataria 2017-05-05 17:53:19 UTC
Shveta,

I was not able to recreate on https://10.16.6.103
Version 5.8.0.13-rc2-nightly.20170504223201_4cd3f14 

Were you able to recreate on https://10.16.6.103. If yes, can you send/attach logs, I can try to look at those to see if i find anything odd in there.

Thanks,
~Harpreet

Comment 6 Shveta 2017-05-05 18:16:06 UTC
Steps to recreate : Add a new dialog 
Add tab , add another tab , validation to add box will be shown.
Add box, Add element , Add another element .
Validation message is shown . Can't add another element .

Dave - Not a blocker as this happens only when you get a validation while adding dialog , Once you got a validation , second element cannot be added .

Comment 7 Harpreet Kataria 2017-05-08 13:40:54 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/1306

Comment 8 CFME Bot 2017-05-08 17:53:12 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/b66aa8df963c73749c75e2f867c3a9023188473c

commit b66aa8df963c73749c75e2f867c3a9023188473c
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 8 09:37:19 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon May 8 10:01:08 2017 -0400

    Clear out all dialog resources before adding/validating.
    
    Clear out all dialog resources to make sure there is no invalid resources left from previous invalid transaction.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448274

 .../miq_ae_customization_controller/dialogs.rb     |  2 +-
 .../dialogs_spec.rb                                | 78 ++++++++++++++++++++++
 2 files changed, 79 insertions(+), 1 deletion(-)

Comment 10 Shveta 2017-10-18 17:54:40 UTC
Fixed in 5.9.0.2.20171010190026_0413a06