Bug 1448356

Summary: [WALA] Fail to clean up the "NotInstalled" extension
Product: Red Hat Enterprise Linux 7 Reporter: Yuxin Sun <yuxisun>
Component: WALinuxAgentAssignee: Vitaly Kuznetsov <vkuznets>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: low    
Version: 7.4CC: borisb, brendand, danis, hkrijger, jopoulso, leiwang, stephen.zarkos, wshi, yujiang, yuxisun
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1448361 (view as bug list) Environment:
Last Closed: 2017-06-19 11:21:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1448361    

Description Yuxin Sun 2017-05-05 09:32:33 UTC
Description of problem:
Clean up extension failed if extension status is "NotInstalled"

Version-Release number of selected component (if applicable):
WALinuxAgent-2.2.10-1

RHEL Version:
RHEL-7.4/6.9

How reproducible:
100%

Steps to Reproduce:
1. Prepare a VM in Azure with an extension installed. (Such as, run "reset remote access" to install the VMAcccessLinux extension)
2. Change extension status to "NotInstalled"
# echo -n "NotInstalled" > /var/lib/waagent/Microsoft.OSTCExtensions.VMAccessForLinux-1.4.6.0/config/HandlerState
3. Wait for 25 seconds. Check if /var/lib/waagent/Microsoft.OSTCExtensions.VMAccessForLinux-1.4.6.0 folder is removed.

Actual results:
The extension folder is not removed

Expected results:
The extension folder is removed

Additional info:
In exthandlers.py line#565:
    existing_state == ExtHandlerState.NotInstalled:
It should be:
    existing_state_text == ExtHandlerState.NotInstalled:

Comment 2 Yuxin Sun 2017-05-05 09:35:32 UTC
Will be fixed in WALA-2.2.11

Comment 3 Yuxin Sun 2017-06-19 11:21:20 UTC
Verify in WALinuxAgent-2.2.12-1.
The logic is changed. Won't remove the extension if set "NotInstalled" in HandlerState file.
Result is Pass. Close this issue.