Bug 1448690
| Summary: | RHV provider refresh fail on "undefined method `split' for nil:NilClass" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ilanit Stein <istein> | ||||||
| Component: | Providers | Assignee: | Moti Asayag <masayag> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ilanit Stein <istein> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.8.0 | CC: | cpelland, jfrey, jhardy, jzmeskal, masayag, obarenbo, simaishi | ||||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||||
| Target Release: | 5.9.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | rhev, provider refresh | ||||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1449193 1524187 (view as bug list) | Environment: | |||||||
| Last Closed: | 2018-03-06 15:49:06 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | Bug | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | RHEVM | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1449193, 1524187 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ilanit Stein
2017-05-07 07:11:20 UTC
Created attachment 1276840 [details]
evm.log
Created attachment 1276841 [details]
rhevm.log
On CFME, A consecutive full refresh succeed. Source Host details page still show there is a VM running on it, though there isn't (Host 'vdsClient -s 0 list table' return No VMs). New commit detected on ManageIQ/ovirt/master: https://github.com/ManageIQ/ovirt/commit/3ac5cc03dd9da68bb2d24df007254f773f0dce66 commit 3ac5cc03dd9da68bb2d24df007254f773f0dce66 Author: Moti Asayag <masayag> AuthorDate: Mon May 8 15:31:08 2017 +0300 Commit: Moti Asayag <masayag> CommitDate: Mon May 8 17:45:07 2017 +0300 Fix host targeted refresh In V3 the host resources retrieved by /ovirt-engine/api/hosts/{host:id} contains the statistics element. The statistics element contains a reference to the host element. The xpath used to collect similar host elements considered the host sub-element of the statistics as a resource to collect, which lead to collecting the same host multiple times. By specifying the exact top level host path, this will be avoided. https://bugzilla.redhat.com/show_bug.cgi?id=1448690 lib/ovirt/service.rb | 5 +++-- spec/service_spec.rb | 61 +++++++++++++++++++++++++++++++++------------------- 2 files changed, 42 insertions(+), 24 deletions(-) New commit detected on ManageIQ/manageiq-providers-ovirt/master: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/6c468f674d341a1ad27664245136c74c85c1e262 commit 6c468f674d341a1ad27664245136c74c85c1e262 Author: Moti Asayag <masayag> AuthorDate: Mon May 8 14:46:23 2017 +0300 Commit: Moti Asayag <masayag> CommitDate: Mon May 8 20:52:40 2017 +0300 Fix host targeted refresh The PR handles two issues with host targeting refresh: 1. When targeting a refresh of a single host, no vms or templates are reported. Therefore the vm or template collected array should be handled in case of nil. 2. In V3 the host resources retrieved by /ovirt-engine/api/hosts/{host:id} contains the statistics element. The statistics element contains a reference to the host element. The xpath used to collect similar host entries considered the host sub-element as a resource to collect, which lead to collecting the same host multiple times. By specifying the exact top level host path, this will be avoided. https://bugzilla.redhat.com/show_bug.cgi?id=1448690 .../providers/redhat/infra_manager/refresh/parse/parser.rb | 2 +- lib/manageiq/providers/ovirt/legacy/inventory.rb | 9 +++++---- manageiq-providers-ovirt.gemspec | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) New commit detected on ManageIQ/manageiq-gems-pending/fine: https://github.com/ManageIQ/manageiq-gems-pending/commit/d7d3c1979eb0c6ac1bc5dce6957eadb8a73787de commit d7d3c1979eb0c6ac1bc5dce6957eadb8a73787de Author: Moti Asayag <masayag> AuthorDate: Tue May 9 16:56:08 2017 +0300 Commit: Moti Asayag <masayag> CommitDate: Tue May 9 17:05:51 2017 +0300 [FINE] Fix host targeted refresh In V3 the host resources retrieved by /ovirt-engine/api/hosts/{host:id} contains the statistics element. The statistics element contains a reference to the host element. The xpath used to collect similar host entries considered the host sub-element as a resource to collect, which lead to collecting the same host multiple times. By specifying the exact top level host path, this will be avoided. https://bugzilla.redhat.com/show_bug.cgi?id=1448690 lib/gems/pending/ovirt_provider/inventory/ovirt_inventory.rb | 9 +++++---- manageiq-gems-pending.gemspec | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) Verified on: CFME 5.9.0.4 RHV 4.1.7.4 Verification steps: I followed reproduction steps and the problematic behaviour was not encountered. Migrated VM is no longer shown as running on the source host and on error was found in evm.log during provider refresh. New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/acf72e5020e11a81ecfcd962825cb11332faa634 commit acf72e5020e11a81ecfcd962825cb11332faa634 Author: Moti Asayag <masayag> AuthorDate: Sat Dec 9 11:27:09 2017 +0200 Commit: Moti Asayag <masayag> CommitDate: Sun Dec 10 13:02:21 2017 +0200 [EUWE] Fix host targeted refresh The PR handles two issues with host targeting refresh: 1. When targeting a refresh of a single host, no vms or templates are reported. Therefore the vm or template collected array should be handled in case of nil. 2. In V3 the host resources retrieved by /ovirt-engine/api/hosts/{host:id} contains the statistics element. The statistics element contains a reference to the host element. The xpath used to collect similar host entries considered the host sub-element as a resource to collect, which lead to collecting the same host multiple times. By specifying the exact top level host path, this will be avoided. https://bugzilla.redhat.com/show_bug.cgi?id=1448690 .../manageiq/providers/redhat/infra_manager/refresh_parser.rb | 2 +- app/models/manageiq/providers/redhat/infra_manager/refresher.rb | 4 +++- gems/pending/Gemfile | 2 +- gems/pending/ovirt_provider/inventory/ovirt_inventory.rb | 9 +++++---- 4 files changed, 10 insertions(+), 7 deletions(-) |