Bug 1448864

Summary: Seeing error "Failed to get the total number of files. Unable to estimate time to complete rebalance" in rebalance logs
Product: [Community] GlusterFS Reporter: Nithya Balachandran <nbalacha>
Component: distributeAssignee: Nithya Balachandran <nbalacha>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.10CC: amukherj, bugs, rhinduja, rtalur, tdesala
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.10.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1448640
: 1454853 (view as bug list) Environment:
Last Closed: 2017-05-31 20:44:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1448640    
Bug Blocks: 1442603, 1446165, 1454853    

Description Nithya Balachandran 2017-05-08 13:03:58 UTC 
+++ This bug was initially created as a clone of Bug #1448640 +++

+++ This bug was initially created as a clone of Bug #1446165 +++

Description of problem:
=======================
Seeing error "Failed to get the total number of files. Unable to estimate time to complete rebalance" in rebalance logs

Version-Release number of selected component (if applicable):
3.8.4-24.el7rhgs.x86_64

How reproducible:
1/1

Steps to Reproduce:
===================
1) Create a distributed-replicate volume and start it.
2) FUSE mount on a client.
3) Add few bricks and start rebalance. (This error is seen during remove-brick as well)

Note: This error says it is unable to estimate the time to complete rebalance but we are able to see the rebalance estimate time during add-brick or remove-brick rebalance.

Actual results:
===============
Seeing error "Failed to get the total number of files. Unable to estimate time to complete rebalance" in rebalance logs

Expected results:
=================
We should not see error "Failed to get the total number of files. Unable to estimate time to complete rebalance" in rebalance logs.


--- Additional comment from Nithya Balachandran on 2017-05-02 23:49:08 EDT ---

This is a bug:


In dht-rebalance.c:


ret = gf_defrag_total_file_cnt (this, &loc);                    
if (!ret) {                                                     
        gf_msg (this->name, GF_LOG_ERROR, 0, 0, "Failed to get "
                "the total number of files. Unable to estimate "
                "time to complete rebalance.");                 
}   

This should be 

if (ret) {
 ...

}

--- Additional comment from Worker Ant on 2017-05-06 10:32:42 EDT ---

REVIEW: https://review.gluster.org/17197 (cluster/dht Fix ret check) posted (#1) for review on master by N Balachandran (nbalacha)

--- Additional comment from Worker Ant on 2017-05-08 00:04:02 EDT ---

REVIEW: https://review.gluster.org/17197 (cluster/dht: Fix ret check) posted (#2) for review on master by N Balachandran (nbalacha)

--- Additional comment from Worker Ant on 2017-05-08 00:47:40 EDT ---

COMMIT: https://review.gluster.org/17197 committed in master by Raghavendra G (rgowdapp) 
------
commit 67598f538efb24a9e5ac561b294a05e707e15761
Author: N Balachandran <nbalacha>
Date:   Sat May 6 20:01:16 2017 +0530

    cluster/dht: Fix ret check
    
    Fixed an incorrect return code check in the rebalance
    code.
    
    Change-Id: I60804ff121cec7a2f0419e2ee70dd22ea7533c0c
    BUG: 1448640
    Signed-off-by: N Balachandran <nbalacha>
    Reviewed-on: https://review.gluster.org/17197
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
Comment 1 Worker Ant 2017-05-08 13:16:22 UTC 
REVIEW: https://review.gluster.org/17204 (cluster/dht: Fix ret check) posted (#1) for review on release-3.10 by N Balachandran (nbalacha)
Comment 2 Worker Ant 2017-05-10 06:29:21 UTC 
COMMIT: https://review.gluster.org/17204 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit e36b0532346131591089fe62e23b8c519b1e3651
Author: N Balachandran <nbalacha>
Date:   Sat May 6 20:01:16 2017 +0530

    cluster/dht: Fix ret check
    
    Fixed an incorrect return code check in the rebalance
    code.
    
    > BUG: 1448640
    > Signed-off-by: N Balachandran <nbalacha>
    > Reviewed-on: https://review.gluster.org/17197
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Raghavendra G <rgowdapp>
    (cherry picked from commit 67598f538efb24a9e5ac561b294a05e707e15761)
    
    Change-Id: I60804ff121cec7a2f0419e2ee70dd22ea7533c0c
    BUG: 1448864
    Signed-off-by: N Balachandran <nbalacha>
    Reviewed-on: https://review.gluster.org/17204
    Reviewed-by: MOHIT AGRAWAL <moagrawa>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
Comment 3 Raghavendra Talur 2017-05-31 20:44:48 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.