Bug 1448905

Summary: Amend is allowed when VM is up
Product: [oVirt] ovirt-engine Reporter: Avihai <aefrat>
Component: BLL.StorageAssignee: Maor <mlipchuk>
Status: CLOSED CURRENTRELEASE QA Contact: Avihai <aefrat>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.1.2.1CC: bugs, stirabos
Target Milestone: ovirt-4.1.3Flags: rule-engine: ovirt-4.1+
rule-engine: blocker+
Target Release: 4.1.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-06 13:22:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine & vdsm logs
none
rest get disk and snapshot disk content none

Description Avihai 2017-05-08 15:26:13 UTC
Created attachment 1277123 [details]
engine & vdsm logs

Description of problem:
Amend is allowed when VM & disk is up and running which can cause data/image corruption. 

Version-Release number of selected component (if applicable):
rhevm-4.1.2-0.1.el7.noarch
VDSM:
4.19.11-1

How reproducible:
100%

Steps to Reproduce:
1. Create DC + cluster on v3
2. Create a VM with thin disk and one snapshot
3. Upgrade cluster &DC to version 4
4. Start the VM
5. Attempt to amend the disk & snapshot disks -> should fail


Actual results:
Amend is allowed & upgrade disk + snapshot disks.

Expected results:
Amend should be blocked as VM is running 

Additional info:
Timeline:
May 8, 2017, 5:21:09 PM
vm_TestCase18347_REST_NFS_0817181457_Disk1 has been amended successfully.

May 8, 2017, 5:21:03 PM
VM vm_TestCase18347_REST_NFS_0817181457 vm_TestCase18347_REST_NFS_0817181457_Disk1 disk was updated by admin@internal-authz.

May 8, 2017, 5:21:03 PM
Started to amend vm_TestCase18347_REST_NFS_0817181457_Disk1

May 8, 2017, 5:20:10 PM
User admin@internal-authz logged in.

May 8, 2017, 5:19:55 PM
VM vm_TestCase18347_REST_NFS_0817181457 started on Host host_mixed_1

Comment 1 Avihai 2017-05-08 15:37:29 UTC
Created attachment 1277126 [details]
rest get disk and snapshot disk content

Comment 2 Avihai 2017-05-29 09:04:52 UTC
verified at 4.1.3-0.1