Bug 1448971

Summary:	Service Dialog Check Box Required Field Cannot be Unchecked if previously set
Product:	Red Hat CloudForms Management Engine	Reporter:	Jeffrey Cutter <jcutter>
Component:	UI - OPS	Assignee:	eclarizi
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.7.0	CC:	hkataria, jhardy, mpovolny, obarenbo, pjakobs, simaishi
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	service:dialog
Fixed In Version:	5.9.0.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-01 13:12:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeffrey Cutter 2017-05-08 23:00:06 UTC

Description of problem:

If you create a service dialog with a chcek box and you mark the check box as required, and save it, future attempts to uncheck the required box for that check box do not work.  It appears OK, but upon reediting it is apparent the Required is marked as required still.  Also, utilizing the service dialog from a catalog item indicates that the field is required.

I'm not sure a Required option even makes sense for a checkbox.  A check box's existence on the form means it's either true or false.  Making it required has the effect of not being able to submit the request unless the check box is checked which I do not think is the intent.

Version-Release number of selected component (if applicable):

5.7.1.3.20170221135006_818f133

How reproducible:

Every time.

Comment 2 Greg McCullough 2017-05-12 15:40:15 UTC

I questions the same thing when this feature was first requested, but the use-cases for supporting the required flag on the checkbox makes sense.

The main use-case is enforce ackownlgedgment of something before the dialog can be submitted.  This could be a "Do you agree to the terms?" type of question or just validating that the user interacts with the dialog instead of just pressing submit.

Comment 3 Peter Jakobs 2017-09-28 11:01:15 UTC

I have added this to the case already:
the request is not with regards to the GUI (although the term "ceckbox" is leading to that thought) but the API. If they have a checkbox item, and the request comes through the API, they want to enforce that it's either true or false but not omitted. I think in that way, it does makes sense.

pj

Comment 5 eclarizi 2017-10-19 15:45:16 UTC

This should be fixed by this commit:
https://github.com/ManageIQ/manageiq/commit/7a95d49b47b434cbd3d6e7d2b223ebdc53fe33e0

Which originated from this BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1495971

Comment 6 Shveta 2017-11-01 05:03:02 UTC

Fixed in 5.9.0.4.20171024163837_ef71ea6

Comment 9 errata-xmlrpc 2018-03-01 13:12:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380