Bug 1448987
Summary: | NM does not use new route when adding host route for DHCP server | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Jonathan Maxwell <jmaxwell> | ||||||
Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
Severity: | high | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | 7.3 | CC: | aloughla, atragler, bgalvani, fgiudici, lrintel, rkhan, sukulkar, thaller, vbenes | ||||||
Target Milestone: | rc | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | NetworkManager-1.8.0-3.el7 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2017-08-01 09:28:57 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Jonathan Maxwell
2017-05-09 02:09:08 UTC
Hi, it's wrong that NM adds such route because the DHCP server is already reachable through the existing routes pushed by the server. Also, the way in which the route gateway is chosen is wrong because it doesn't consider the static routes, but only the default gateway. I think that the fix for bug 983325 was implemented in the wrong way. I wonder if that fix should exist at all, considering that: - dhclient script doesn't implement at all such logic (it has some code to add direct routes to the *gateway* if not directly reachable) - if needed, the server can be configured to push the missing route to be reached by the client in the classless-routes options So, in my opinion that code should be removed or at least fixed to add the route only when strictly necessary. (In reply to Beniamino Galvani from comment #2) > Hi, > > it's wrong that NM adds such route because the DHCP server is already > reachable through the existing routes pushed by the server. Also, the > way in which the route gateway is chosen is wrong because it doesn't > consider the static routes, but only the default gateway. I think that > the fix for bug 983325 was implemented in the wrong way. > > I wonder if that fix should exist at all, considering that: > > - dhclient script doesn't implement at all such logic (it has some > code to add direct routes to the *gateway* if not directly > reachable) > > - if needed, the server can be configured to push the missing route > to be reached by the client in the classless-routes options > They are using the above to add classless-static routes already. > So, in my opinion that code should be removed or at least fixed to add > the route only when strictly necessary. Hi, Thanks for looking into this. I agree. That makes sense. Otherwise customers with more than one router on a subnet will have problems. Created attachment 1277653 [details]
[PATCH] dhcp: don't add route to DHCP4 server
Created attachment 1277654 [details]
Routed DHCP test script
For future memory: a simple script to test scenarios like this
(In reply to Beniamino Galvani from comment #4) > Created attachment 1277653 [details] > [PATCH] dhcp: don't add route to DHCP4 server lgtm I agree on #c2. Route to DHCP server should be managed in DHCP server configuration in classless-routes options. Patch lgtm Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:2299 |