Bug 1449430

Created attachment 1277475 [details]
[patch] Update to 5.10.2 (#1449430)

hotness's scratch build of rubygem-minitest-5.10.2-1.el7.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=19481602

This breaks Rails:

https://github.com/rails/rails/pull/29022

mtasaka's rubygem-minitest-5.10.2-100.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=889799

Pushed, seems that new rails is to be released:
https://github.com/rails/rails/issues/29038

Are you planning to update F26 as well? My concern is Ruby on Rails 5.1 change proposal, which is pvalena about to propose any moment ...

I can simply backport the fix to both F26 and F27, as those branches are identical atm.

(In reply to Vít Ondruch from comment #6)
> Are you planning to update F26 as well? My concern is Ruby on Rails 5.1
> change proposal, which is pvalena about to propose any moment ...

Most probably. If rails is to be upgraded to 5.1 "soon" on F-26, perhaps it is better that minitest is updated to 5.10.2 on F-26 _before_ rails 5.1 build comes on F-26 (to make F-26/27 rubygem-rails tree identical)?

The plan is currently to push Rails 5.1 to F27 only. I don't think we should update rails in F26. Neither I think we want to update F27 to the latest 5.0.x ATM, since it would be wasted time IMO. So the process should be:

1. Patch rubygem-railties in F27 (and F26 if you are going to update minitest there).
2. Go ahead with the change proposal and update Rails in F27 to 5.1 (this might take like 3 weeks or so?)
3. Update F26 to the latest Rails 5.0.x

Umm.... it seems with minitest 5.10.2, railties 5.0.2 with https://github.com/rails/rails/pull/29022 patched fails at the different places as below:

[mockbuild@8b717e463bbf40a09684018a9c73f597 railties]$ ruby -Itest test/application/test_runner_test.rb
Run options: --seed 11621

# Running:

...F...../builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:5: warning: already initialized constant LoadError::REGEXPS
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:5: warning: previous definition of REGEXPS was here
/builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:31: warning: already initialized constant MissingSourceFile
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:31: warning: previous definition of MissingSourceFile was here
...S...S/builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:5: warning: already initialized constant LoadError::REGEXPS
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:5: warning: previous definition of REGEXPS was here
/builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:31: warning: already initialized constant MissingSourceFile
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:31: warning: previous definition of MissingSourceFile was here
....S..............S....../builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:5: warning: already initialized constant LoadError::REGEXPS
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:5: warning: previous definition of REGEXPS was here
/builddir/build/BUILD/rubygem-railties-5.0.2/usr/share/gems/gems/activesupport/lib/active_support/core_ext/load_error.rb:31: warning: already initialized constant MissingSourceFile
/usr/share/gems/gems/activesupport-5.0.2/lib/active_support/core_ext/load_error.rb:31: warning: previous definition of MissingSourceFile was here
...

Finished in 49.139878s, 0.9361 runs/s, 3.6020 assertions/s.

  1) Failure:
ApplicationTests::TestRunnerTest#test_only_inline_failure_output [test/application/test_runner_test.rb:488]:
Expected /Finished in.*\n\n1 runs, 1 assertions/ to match "Run options: --seed 45149\n\n# Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth [/tmp/d20170513-6514-1mkcggi/app/test/models/post_test.rb:6]:\nwups!\n\nbin/rails test test/models/post_test.rb:4\n\n\n\nFinished in 0.002132s, 468.9343 runs/s, 468.9343 assertions/s.\n1 runs, 1 assertions, 1 failures, 0 errors, 0 skips\n".

46 runs, 177 assertions, 1 failures, 0 errors, 4 skips

Yet another:

DEBUG: * Test file: test/generators/plugin_test_runner_test.rb
DEBUG: Run options: --seed 52506
DEBUG: # Running:
DEBUG: .F.......
DEBUG: Finished in 20.520469s, 0.4386 runs/s, 1.1208 assertions/s.
DEBUG:   1) Failure:
DEBUG: PluginTestRunnerTest#test_only_inline_failure_output [test/generators/plugin_test_runner_test.rb:74]:
DEBUG: Expected /Finished in.*\n\n1 runs, 1 assertions/ to match "Run options: --seed 40737\n\n# Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth [/tmp/bukkits20170513-3920-jnnl43/bukkits/test/post_test.rb:6]:\nwups!\n\nbin/test /tmp/bukkits20170513-3920-jnnl43/bukkits/test/post_test.rb:4\n\n\n\nFinished in 0.002230s, 448.4631 runs/s, 448.4631 assertions/s.\n1 runs, 1 assertions, 1 failures, 0 errors, 0 skips\n".
DEBUG: 9 runs, 23 assertions, 1 failures, 0 errors, 0 skips
DEBUG: xargs: sh: exited with status 255; aborting

Looks like minitest 5.10.2 removes one extra newline, so regex does not match. Maybe before upstream releases rails 5.1.1, perhaps some extra work is required?

rubygem-railties-5.0.2-3.fc26 rubygem-minitest-5.10.2-100.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43c73485df

Pity I've missed BZs email somehow. I have tried to send a build few hours after yours. I have also created PR for the Rails tests:

https://github.com/rails/rails/pull/29065

rubygem-minitest-5.10.2-100.fc26, rubygem-railties-5.0.2-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43c73485df

rubygem-minitest-5.10.2-100.fc26, rubygem-railties-5.0.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.