Bug 1449470
| Summary: | Review Request: python3-coverage - Code coverage testing module for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aurelien Bompard <aurelien> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-25 13:40:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Aurelien Bompard
2017-05-10 05:28:02 UTC
Taking this review. fedora-review failed:
> WARNING: Cannot download url: http://pypi.python.org/packages/source/c/coverage/coverage-4.4.tar.gz
> BuildRequires: python3-pkgversion-macros
This package has been superseded by "python-srpm-macros" and thus doesn't build in Rawhide anymore. Please replace.
Fixed and updated to 4.4.1, thanks. Spec URL: https://abompard.fedorapeople.org/reviews/python3-coverage/python3-coverage.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python3-coverage/python3-coverage-4.4.1-1.el7.centos.src.rpm - rpmlint issue: * python3-coverage.src: W: invalid-license GPL Please fix the license field so that the license tags are correct. Fixed, thanks. One of the files specifies GPLv2, the other two GPL files don't specify a version. The original python-coverage package had a licence tag without the version on the GPL, should I keep it that way? Spec URL: https://abompard.fedorapeople.org/reviews/python3-coverage/python3-coverage.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python3-coverage/python3-coverage-4.4.1-1.el7.centos.src.rpm (In reply to Aurelien Bompard from comment #6) > Fixed, thanks. One of the files specifies GPLv2, the other two GPL files > don't specify a version. The original python-coverage package had a licence > tag without the version on the GPL, should I keep it that way? > My understanding is that all of the files are actually MIT / GPLv2. The unbundled JavaScript packages appear to be MIT or GPLv2 explicitly, at least according to the author[1][2] for the first, and Debian for the last two[3][4]. [1]: https://github.com/cowboy/jquery-throttle-debounce [2]: http://benalman.com/about/license/ [3]: http://metadata.ftp-master.debian.org/changelogs/main/libj/libjs-jquery-hotkeys/libjs-jquery-hotkeys_0~20130707+git2d51e3a9+dfsg-2_copyright [4]: http://metadata.ftp-master.debian.org/changelogs/main/libj/libjs-jquery-isonscreen/libjs-jquery-isonscreen_1.2.0-1_copyright python-coverage should be appropriately fixed. Review notes: - Follows Python packaging guidelines for EPEL - Builds and installs - No rpmlint issues of note - No fedora-review issues of note PACKAGE APPROVED. Thanks for your excellent review, Neal. There were two parallel reviews of this package, the other one was added before this one, so I'll join forces with the other maintainer. Thanks and sorry for the duplicated effort. *** This bug has been marked as a duplicate of bug 1294860 *** |