Bug 1449576

Summary: Need enable DefaultTolerationSeconds admission controller
Product: OpenShift Container Platform Reporter: DeShuai Ma <dma>
Component: NodeAssignee: Avesh Agarwal <avagarwa>
Status: CLOSED ERRATA QA Contact: DeShuai Ma <dma>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, decarr, jokerman, mmccomas, smunilla, wmeng
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-10 05:23:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description DeShuai Ma 2017-05-10 09:50:59 UTC
Description of problem:
After configure DefaultTolerationSeconds, then create pod, it can't add default toleration to pod.

Version-Release number of selected component (if applicable):
openshift v3.6.74
kubernetes v1.6.1+5115d708d7
etcd 3.1.0

How reproducible:
Always

Steps to Reproduce:
1. enable DefaultTolerationSeconds like below
admissionConfig:
  pluginConfig:
    DefaultTolerationSeconds:
      configuration:
        kind: DefaultAdmissionConfig
        apiVersion: v1
        disable: false
2. create a pod then check the pod Tolerations
[root@host-8-174-52 ~]# oc create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/k8s/pod/hello-pod.yaml -n dma
pod "hello-pod" created
[root@host-8-174-52 ~]# oc describe po hello-pod -n dma|grep -i tolera
Tolerations:    <none>

Actual results:


Expected results:
2.Should add default toleration to pod when configure DefaultTolerationSeconds.

Additional info:
//In upstream
after enable DefaultTolerationSeconds, Then create a pod, pod will be added a default toleration
[root@ip-172-18-13-114 ~]# kubectl create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/k8s/pod/hello-pod.yaml
pod "hello-pod" created
[root@ip-172-18-13-114 ~]# kubectl describe po hello-pod | grep -i toleration
Tolerations:    node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s

Comment 1 DeShuai Ma 2017-05-10 09:51:52 UTC
This will be fixed by https://github.com/openshift/origin/pull/14118

Comment 3 DeShuai Ma 2017-06-05 10:03:32 UTC
Verify on openshift v3.6.94

1. enable DefaultTolerationSeconds like below
admissionConfig:
  pluginConfig:
    DefaultTolerationSeconds:
      configuration:
        kind: DefaultAdmissionConfig
        apiVersion: v1
        disable: false
[root@qe-dma36-master-1 ~]# oc create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/k8s/pod/hello-pod.yaml -n dma
pod "hello-pod" created
[root@qe-dma36-master-1 ~]# oc get po -n dma
NAME        READY     STATUS    RESTARTS   AGE
hello-pod   1/1       Running   0          2m
[root@qe-dma36-master-1 ~]# oc describe po hello-pod -n dma|grep -i tolera
Tolerations:	node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s

Comment 5 errata-xmlrpc 2017-08-10 05:23:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716