Bug 1449697

Summary: Persist passenger customisations from the perf & scaling tuning guide
Product: Red Hat Satellite Reporter: Julio Entrena Perez <jentrena>
Component: DocumentationAssignee: Pradeep Kumar Surisetty <psuriset>
Status: CLOSED CURRENTRELEASE QA Contact: satellite-doc-list
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2.9CC: aperotti, bbuckingham, bkearney, ehelms, ekohlvan, fgarciad, jcallaha, jentrena, ktordeur, mmccune, mvanderw, psuriset, rbeyel, sbadhwar, stbenjam, tbhowmik, tbrisker
Target Milestone: UnspecifiedKeywords: Performance, Triaged
Target Release: Unused   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-06 21:17:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
2016 - Performance & Scale Tuning of Satellite 6.2 and Capsules none

Description Julio Entrena Perez 2017-05-10 13:15:33 UTC 
Created attachment 1277617 [details]
2016 - Performance & Scale Tuning of Satellite 6.2 and Capsules

Description of problem:
Page 17 of the performance and scale tuning guide for Satellite 6.2 available at https://access.redhat.com/articles/2626101 suggests to customise the following settings in the following files:

- File /etc/httpd/conf.d/05-foreman-ssl.conf
  PassengerMaxPoolSize
  PassengerMaxRequestQueueSize
  PassengerStatThrottleRate
  PassengerMaxRequests

- File /etc/httpd/conf.d/25-puppet.conf
  PassengerMinInstances
  PassengerStartTimeout
  PassengerMaxPreloaderIdleTime
  PassengerMaxRequests
  PassengerPreStart

Currently when the installer runs, for example when upgrading to the next minor release, these customisations are wiped and replaced with the default values.

There does not seem to be any way of persisting these changes across executions of the installer in file /etc/foreman-installer/custom-hiera.yaml .

This results in minor upgrades bringing back previous issues if customers aren't vigilant and re-apply the changes after each upgrade.

We should provide a way to persist these changes in /etc/foreman-installer/custom-hiera.yaml

Version-Release number of selected component (if applicable):
foreman-installer-1.11.0.15-2.el7sat

How reproducible:
Always

Steps to Reproduce:
1. Customise the settings as per above
2. Run "satellite-installer --scenario satellite --upgrade"
3. Check for the previously applied customisations

Actual results:
Customisations are gone.

Expected results:
Customisations are there after the execution of the installer.

Additional info:
Comment 6 Eric Helms 2017-07-12 15:46:45 UTC 
This is a breakdown of how each item can be set, and which items can be set globally and which can be set per vhost. To begin with, the one value that cannot be set at all currently for the puppet vhost:

PassengerMaxPreloaderIdleTime

For puppet vhost:

  PassengerMinInstances: can be set with --puppet-passenger-min-instances
  PassengerPreStart: can be set with --puppet-passenger-pre-start


Globally, that is, it affects both Foreman and Puppet vhosts, the following are set by default in hiera and can be customized:

  PassengerMaxPoolSize: set to 12 by default
  PassengerMaxRequestQueueSize: set to 250 by default
  PassengerStatThrottleRate: set to 120 by default
  PassengerMaxRequests: set to 10000 by default

The following have to be set by the user using a custom hiera config:

  PassengerStartTimeout


Given PassengerMaxPreloaderIdleTime has no current way to set it, I would ask what effect it has on the tuning. Further, I would recommend splitting that out to its own BZ and consider the rest of whats laid out here to be done and part of this BZ.
Comment 16 Mike McCune 2018-11-06 21:17:17 UTC 
This is resolved and able to be set in custom-heira.yaml in 6.3 and later