Bug 1449887

Summary: The buttons hint display as different style in cockpit dashboard server list.
Product: Red Hat Enterprise Linux 7 Reporter: Wei Wang <weiwang>
Component: cockpitAssignee: Peter <pvolpe>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: low Docs Contact:
Priority: medium    
Version: 7.4CC: bugs, cshao, huzhao, leiwang, mpitt, qiyuan, rbarry, weiwang, yaniwang, ycui
Target Milestone: pre-dev-freezeKeywords: Extras
Target Release: 7.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-19 15:18:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
add server picture
none
edit server picture none

Description Wei Wang 2017-05-11 05:31:29 UTC
Created attachment 1277747 [details]
add server picture

Description of problem:
In cockpit dashboard server list, the hint of "add server" button and "edit server" button display as the different style.
    1) The hint of "add server" displays as black background, white font.
    2) The hint of "edit server" displays as yellow background, black font.
    3) The board style is also different.

Version-Release number of selected component (if applicable):
redhat-virtualization-host-4.1-20170506.0
cockpit-ws-135-4.el7.x86_64
cockpit-dashboard-135-4.el7.x86_64
cockpit-ovirt-dashboard-0.10.7-0.0.18.el7ev.noarch
imgbased-0.9.24-0.1.el7ev.noarch


How reproducible:
100%


Steps to Reproduce:
1. Clean install redhat-virtualization-host-4.1-20170506.0
2. Login to cockpit webUI with root account
3. Go to "Dashboard" page, hover mouse over "add server" button and "edit server" button


Actual results:
The hint of "add server" button and "edit server" button display as the different style.


Expected results:
The hint of "add server" button and "edit server" button display as the same style.


Additional info:

Comment 1 Wei Wang 2017-05-11 05:34:49 UTC
Created attachment 1277748 [details]
edit server picture

Comment 2 Wei Wang 2017-05-11 06:02:10 UTC
The bug is detected with firefox-50.1.0-1.fc23.x86_64. firefox 47 and chrome don't have this issue.

Comment 3 cshao 2017-05-11 06:07:28 UTC
Is a cosmetic issue and no function effect, so set low severity.

Comment 5 Dominik Perpeet 2017-08-28 11:26:50 UTC
Is the ovirt dashboard overriding the cockpit one?

Or is the delete/remove button hidden?

The edit button should use patternfly edit since at least 0.33
https://github.com/cockpit-project/cockpit/commit/2b12461225034eefc309397eda4eab4ee23c2bd3

Please confirm this bug is in the Cockpit dashboard.

Comment 6 Wei Wang 2017-08-29 02:08:09 UTC
(In reply to Dominik Perpeet from comment #5)
> Is the ovirt dashboard overriding the cockpit one?
> 
No, the function of adding the remote server exists in cockpit dashboard.

> Or is the delete/remove button hidden?

Yes, the button is hidden when launching cockpit dashboard page. After clicking "Edit Server" button, the delete/remove button is shown. Then click "Edit Server" button again, the delete/remove button is hidden again.
> 
> The edit button should use patternfly edit since at least 0.33
> https://github.com/cockpit-project/cockpit/commit/
> 2b12461225034eefc309397eda4eab4ee23c2bd3
> 
> Please confirm this bug is in the Cockpit dashboard.
Yes, the bug is in the cockpit dashboard.

Comment 7 Peter 2017-08-29 13:05:59 UTC
Fixing upstream.

https://github.com/cockpit-project/cockpit/pull/7581

Comment 10 errata-xmlrpc 2017-10-19 15:18:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2961