Bug 1450102

Summary:	Service dialog is created without extra_vars
Product:	Red Hat CloudForms Management Engine	Reporter:	Dmitry Misharov <dmisharo>
Component:	Automate	Assignee:	Lucy Fu <lufu>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	5.8.0	CC:	cpelland, dmisharo, gmccullo, hkataria, jhardy, mkanoor, mpovolny, obarenbo, tfitzger
Target Milestone:	GA	Keywords:	Reopened, TestOnly, ZStream
Target Release:	5.9.0
Hardware:	All
OS:	All
Whiteboard:	ui:ansible:service
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1459989 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:16:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1459989

Description Dmitry Misharov 2017-05-11 14:20:19 UTC

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.14-rc3.20170509175238_5dbf87a 

How reproducible:
Always

Steps to Reproduce:
1. Enable Embedded Ansible role.
2. Wait until it will be enabled.
3. Add some repository with ansible playbook.
4. Navigate to Services/Catalogs/Catalog Items.
5. Create ansible catalog item, don't add extra_vars, in "Dialog" field choose "Create New".
6. Press "Save" button.
7. Edit that catalog item.
7a. Add some extra_vars.
7b. In "Dialog" field choose "Create New".
8. Navigate to Services/Catalogs/Service Catalogs
9. Order the catalog item.

Actual results:
There are no extra_vars in ordering screen.
Service dialog in Automation/Automate/Customization/Service Dialogs doesn't have entered extra_vars.

Expected results:
Service dialog should have extra_vars, which were added during editing of the catalog item.

Comment 3 Greg McCullough 2017-05-11 19:35:09 UTC

This is working as currently designed.  When the dialog is created it will add fields, if you are updating the catalog item or re-using the dialog as part of a different service it will not automatically update.  The user will need to manually update the dialog to provide the changed extra_var fields.

Comment 4 Dmitry Misharov 2017-05-12 06:06:31 UTC

I didn't reuse existing service dialog, I created a new one during editing if the catalog item.

Comment 5 Greg McCullough 2017-05-12 15:00:36 UTC

This issue needs to be reviewed by development as I was thinking of the logic when updating a catalog item using an existing dialog.

Comment 8 CFME Bot 2017-05-17 16:06:44 UTC

https://github.com/ManageIQ/manageiq/pull/15120

Comment 9 CFME Bot 2017-05-19 14:21:31 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/76bae5b7b826a765d3a0c81a647372be065a703d

commit 76bae5b7b826a765d3a0c81a647372be065a703d
Author:     Lucy Fu <lufu>
AuthorDate: Thu May 18 10:45:07 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Thu May 18 12:02:10 2017 -0400

    Use extra_vars to create a new dialog when editing Ansible playbook service template.
    
    Use the new values in extra_vars to create a new dialog, instead of waiting for the updated job template which may take some time.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450102

 app/models/dialog/ansible_playbook_service_dialog.rb       | 14 +++++++-------
 app/models/service_template_ansible_playbook.rb            |  6 +++---
 spec/models/dialog/ansible_playbook_service_dialog_spec.rb | 14 +++++++-------
 3 files changed, 17 insertions(+), 17 deletions(-)

Comment 11 Dmitry Misharov 2017-10-18 08:47:46 UTC

Verified in 5.9.0.2.20171010190026_0413a06.