Bug 1450310

Summary:	Should set NO_PROXY for atomic while using docker system container
Product:	OpenShift Container Platform	Reporter:	Gan Huang <ghuang>
Component:	Installer	Assignee:	Steve Milner <smilner>
Status:	CLOSED ERRATA	QA Contact:	Gan Huang <ghuang>
Severity:	medium	Docs Contact:
Priority:	low
Version:	3.6.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-10 05:23:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1450307
Bug Blocks:

Description Gan Huang 2017-05-12 08:51:17 UTC

Description of problem:
Currently we only set http_proxy and https_proxy for atomic, this is insufficient for the case that the user needs to set NO_PROXY in /etc/atomic.conf to pull the system container images from the internal registry which doesn't need the proxy.

Version-Release number of selected component (if applicable):
openshift-ansible master branch (last commit id is 593ef65)

How reproducible:
always

Steps to Reproduce:
1. see above
2.
3.

Actual results:
NO_RPOXY not allowed to set in /etc/atomic.conf

Expected results:
Installer should set NO_PROXY in /etc/atomic.conf

Additional info:

Comment 1 Steve Milner 2017-05-12 14:56:24 UTC

NO_PROXY is not supported in /etc/atomic.conf. I've opened up https://github.com/projectatomic/atomic/pull/999 to add it.

Comment 2 Steve Milner 2017-05-12 16:24:02 UTC

PR: https://github.com/openshift/openshift-ansible/pull/4173 (for when atomic:999 is merged)

Comment 3 Steve Milner 2017-05-14 14:32:42 UTC

The PR adds no_proxy to /etc/atomic.conf. However, I don't believe it will be in the current releases so I've added an environment override for the atomic command until atomic:999 is released.

Comment 4 Steve Milner 2017-05-17 14:40:09 UTC

Updated and merged https://github.com/openshift/openshift-ansible/pull/4173

Comment 6 Gan Huang 2017-06-12 07:15:29 UTC

Verified with openshift-ansible-3.6.98-1.git.0.e651d65.el7.noarch.rpm

# grep -nir "no_proxy" /etc/atomic.conf 
26:no_proxy: .cluster.local,openshift-133.xx.redhat.com,openshift-145.xx.redhat.com

Comment 8 errata-xmlrpc 2017-08-10 05:23:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716