Bug 1450435

Summary:	Sending forgotten username to mail causes ISE 500
Product:	Red Hat Satellite 5	Reporter:	Pavel Studeník <pstudeni>
Component:	WebUI	Assignee:	Grant Gainey <ggainey>
Status:	CLOSED DUPLICATE	QA Contact:	Pavel Studeník <pstudeni>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	580	CC:	dyordano, pstudeni, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-29 16:22:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1449727, 1450111

Description Pavel Studeník 2017-05-12 14:13:50 UTC

Description of problem:
I want to sent my forgotten login to mail on page /rhn/help/ForgotCredentials.do and I receive Internal server error.

Version-Release number of selected component (if applicable):
spacewalk-java-2.5.14-84.el6sat.noarch

How reproducible:
always

Steps to Reproduce:
1. create new user with valid email
2. go to /rhn/help/ForgotCredentials.do
3. fill email to "Login Information" and click on "send login"

Actual results:
ISE 500

Expected results:
I receive mail in my box

Additional info:
2017-05-12 17:05:42,328 [TP-Processor3] WARN  org.apache.struts.action.RequestProcessor - Unhandled Exception thrown: class java.lang.NullPointerException
2017-05-12 17:05:42,328 [TP-Processor3] ERROR com.redhat.rhn.frontend.servlets.SessionFilter - Error during transaction. Rolling back
javax.servlet.ServletException: java.lang.NullPointerException
	at org.apache.struts.action.RequestProcessor.processException(RequestProcessor.java:520)
	at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:427)
	at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:228)
.........
	at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
	at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
	at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
	at java.lang.Thread.run(Thread.java:785)
Caused by: 
java.lang.NullPointerException
	at javax.mail.internet.InternetAddress.parse(InternetAddress.java:618)
	at javax.mail.internet.InternetAddress.parseHeader(InternetAddress.java:585)
	at javax.mail.internet.InternetAddress.<init>(InternetAddress.java:100)
	at javax.mail.internet.InternetAddress.<init>(InternetAddress.java:87)
	at com.redhat.rhn.common.messaging.SmtpMail.<init>(SmtpMail.java:80)
	at com.redhat.rhn.frontend.action.help.ForgotCredentialsAction.sendEmail(ForgotCredentialsAction.java:184)
	at com.redhat.rhn.frontend.action.help.ForgotCredentialsAction.lookupLogins(ForgotCredentialsAction.java:166)
	at com.redhat.rhn.frontend.action.help.ForgotCredentialsAction.execute(ForgotCredentialsAction.java:87)
	at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:425)
	... 40 more
2017-05-12 17:05:42,328 [RHN Message Dispatcher] ERROR com.redhat.rhn.common.messaging.ActionExecutor - java.lang.NullPointerException
java.lang.NullPointerException
	at javax.mail.internet.InternetAddress.parse(InternetAddress.java:618)
	at javax.mail.internet.InternetAddress.parseHeader(InternetAddress.java:585)
	at javax.mail.internet.InternetAddress.<init>(InternetAddress.java:100)
	at javax.mail.internet.InternetAddress.<init>(InternetAddress.java:87)
	at com.redhat.rhn.common.messaging.SmtpMail.<init>(SmtpMail.java:80)
	at com.redhat.rhn.frontend.events.BaseMailAction.getMail(BaseMailAction.java:53)
	at com.redhat.rhn.frontend.events.BaseMailAction.execute(BaseMailAction.java:39)
	at com.redhat.rhn.common.messaging.ActionExecutor.run(ActionExecutor.java:69)
	at com.redhat.rhn.common.messaging.MessageDispatcher.run(MessageDispatcher.java:58)
	at java.lang.Thread.run(Thread.java:785

Comment 1 Pavel Studeník 2017-05-12 14:14:37 UTC

It is regression, Satellite 5.7 works good.

Comment 2 Grant Gainey 2017-05-17 20:45:37 UTC

I can't recreate this, on a 5.8 running spacewalk-java-2.5.14-84. Can I get *exact* reproducer steps? And maybe a system to look at where it happens?

Comment 3 Pavel Studeník 2017-05-29 15:07:57 UTC

I checked it with package spacewalk-java-2.5.14-88.el6sat.noarch and it works correct.