Bug 1450477

Summary:	Review Request: ratbagd - the libratbag daemon
Product:	[Fedora] Fedora	Reporter:	Benjamin Tissoires <btissoir>
Component:	Package Review	Assignee:	Peter Hutterer <peter.hutterer>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	btissoir, package-review, peter.hutterer
Target Milestone:	---	Flags:	peter.hutterer: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-18 06:50:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Benjamin Tissoires 2017-05-12 17:24:26 UTC

Spec URL: https://people.freedesktop.org/~tissoire/ratbagd-rpm-v1/ratbagd.spec
SRPM URL: https://people.freedesktop.org/~tissoire/ratbagd-rpm-v1/ratbagd-0.3-1.fc27.src.rpm
Description: ratbagd is a system daemon to introspect and modify configurable mice
Fedora Account System Username: bentiss

Comment 1 Benjamin Tissoires 2017-05-12 17:25:38 UTC

scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19510807

Comment 2 Peter Hutterer 2017-05-23 05:50:18 UTC

for the archives: there was a minor license issue found which is being fixed upstream. Please submit an updated spec/srpm once we have a ratbagd with that bit fixed.

Comment 3 Benjamin Tissoires 2017-06-06 14:23:38 UTC

Spec URL: https://people.freedesktop.org/~tissoire/ratbagd-rpm-v2/ratbagd.spec
SRPM URL: https://people.freedesktop.org/~tissoire/ratbagd-rpm-v2/ratbagd-0.4-1.fc27.src.rpm

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19884525

Comment 4 Peter Hutterer 2017-06-07 01:12:01 UTC

merci, looks like there's still a few things left to do tough

* libratbag dependency upstream is >= 0.6, spec file is still at 0.4

* rpmlint complains: "ratbagd.src: W: spelling-error %description -l en_US nonprivileged -> non privileged, non-privileged, underprivileged
ratbagd.src:23: W: unversioned-explicit-provides python3-ratbagd"
→ please hyphenate non-privileged

* ratbagd-python.noarch: E: wrong-script-interpreter /usr/bin/ratbagctl /usr/bin/env python
→ that's an upstream bug, should be '/usr/bin/env python3', see https://github.com/libratbag/ratbagd/pull/26

* the man page for ratbagctl should be in the -python subpackage

* From  https://fedoraproject.org/wiki/Packaging:Python:
"Must: If you build for a single python runtime you must add %python_provide python-$module so that the current default python is provided from the unversioned python package."
afaict all other conditions are met here.

Comment 5 Benjamin Tissoires 2017-07-18 06:50:39 UTC

ratbagd has been merged into libratbag, so there is no point having a separate package for it anymore. I'll update the requested changes in the libratbag RPM once upstream settle on something.