Bug 1450502

Summary: [RFE] Custom Button must be supported at VM level in Service UI
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - ServiceAssignee: Chris Hale <chhale>
Status: CLOSED ERRATA QA Contact: Shveta <sshveta>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: ckacergu, cpelland, dajo, dclarizi, jhardy, obarenbo, simaishi, sshveta
Target Milestone: GAKeywords: FutureFeature, ZStream
Target Release: 5.8.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.1.0 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1450473 Environment:
Last Closed: 2017-08-02 17:24:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1450473    
Bug Blocks:    
Attachments:
Description Flags
error submitting VM button none

Comment 2 CFME Bot 2017-05-12 20:03:25 UTC
New commit detected on ManageIQ/manageiq-ui-service/fine:
https://github.com/ManageIQ/manageiq-ui-self_service/commit/223c3c1425aa5c4945005764fa4349cba08742fc

commit 223c3c1425aa5c4945005764fa4349cba08742fc
Author:     Chris Kacerguis <chriskacerguis.github.com>
AuthorDate: Fri May 12 13:56:11 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri May 12 15:59:53 2017 -0400

    Merge pull request #750 from chalettu/vm-custom-buttons
    
    Added custom buttons to VM details page
    (cherry picked from commit 4918c1ac4444398983b63540adebb9c03bc94ad9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450502

 client/app/services/vm-details/vm-details.component.js | 10 ++++++++++
 client/app/services/vm-details/vm-details.html         |  4 ++++
 client/app/services/vms.service.js                     |  2 ++
 3 files changed, 16 insertions(+)

Comment 3 CFME Bot 2017-05-18 17:51:21 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/28fa95221971cf0baee0d806e12208d78bd1b6ba

commit 28fa95221971cf0baee0d806e12208d78bd1b6ba
Author:     Alberto Bellotti <abellotti.github.com>
AuthorDate: Wed Apr 26 15:13:14 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu May 18 13:49:51 2017 -0400

    Merge pull request #14817 from imtayadeway/api/vm-custom-actions
    
    Enable custom actions for Vms API
    (cherry picked from commit a1d985ca1dd6be423c8623cef4a740cc6acef4e1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450502

 app/models/mixins/custom_actions_mixin.rb | 43 +++++++++++++++
 app/models/service_template.rb            | 38 ++-----------
 app/models/vm.rb                          |  5 ++
 config/api.yml                            |  1 +
 lib/extensions/ar_miq_set.rb              |  1 +
 spec/factories/custom_button_set.rb       |  8 +++
 spec/requests/api/vms_spec.rb             | 89 +++++++++++++++++++++++++++++++
 7 files changed, 152 insertions(+), 33 deletions(-)
 create mode 100644 app/models/mixins/custom_actions_mixin.rb

Comment 4 Shveta 2017-05-23 18:01:51 UTC
Created attachment 1281681 [details]
error submitting VM button

Able to view custom button on VM but error submitting VM button request.
5.8.0.16.20170522163900_28fa952

Comment 5 Chris Kacerguis 2017-05-23 18:16:09 UTC
From the screenshot that looks to be an older version, can you please retest with the latest build and let us know?

Comment 9 Chris Hale 2017-05-25 19:26:54 UTC
This has been completed as part of GH PR https://github.com/ManageIQ/manageiq-ui-service/pull/791

Comment 10 Shveta 2017-06-29 06:24:57 UTC
Verification blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1466114

Comment 11 Shveta 2017-06-30 15:39:05 UTC
Fixed in 5.8.1.0.20170623170756_3ed4411

Comment 13 errata-xmlrpc 2017-08-02 17:24:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1758