Bug 1450572

Summary:	Review Request: radare2 - Radare is a portable reversing framework
Product:	[Fedora] Fedora	Reporter:	Siddharth Sharma <siddharth.kde>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, opensource, package-review, quantum.analyst
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-23 15:53:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Siddharth Sharma 2017-05-13 09:38:05 UTC

Spec URL: https://siddharths.fedorapeople.org/SPECS/radare2.spec
SRPM URL: https://siddharths.fedorapeople.org/SRPMS/radare2-1.4.0-1.fc27.src.rpm

Description: Radare is a portable reversing framework that can                                                                                                                                                                    
 - Disassemble (and assemble for) many different architectures
 - Debug with local native and remote debuggers (gdb, rap, webui, r2pipe, winedbg, windbg)
 - Run on Linux, *BSD, Windows, OSX, Android, iOS, Solaris and Haiku
 - Perform forensics on filesystems and data carving
 - Be scripted in Python, Javascript, Go and more
 - Support collaborative analysis using the embedded webserver
 - Visualize data structures of several file types
 - Patch programs to uncover new features or fix vulnerabilities
 - Use powerful analysis capabilities to speed up reversing
 - Aid in software exploitation

Fedora Account System Username: siddharths

Comment 1 Siddharth Sharma 2017-05-13 09:39:36 UTC

Also available in:

https://github.com/radare/radare2-release/blob/master/radare2.spec

Comment 2 Artur Frenszek-Iwicki 2017-05-18 18:16:45 UTC

I am not a packager, so this is not an official review.

In the %files section, the following directories are not owned:
%{_docdir}/radare2/
%{_datadir}/%{name}/
%{_datadir}/%{name}/%{version}/

In %files devel, there are also unowned directories:
%{_libdir}/radare2/
%{_libdir}/radare2/%{version}/

Also, rpmlint complains about a bad date:
warning: bogus date in %changelog: Fri May 13 2017

Comment 3 Elliott Sales de Andrade 2017-07-08 10:00:58 UTC

There is an existing review request at bug 1368855.

Comment 4 Till Maas 2017-10-23 15:53:02 UTC

Hi Siddharth, thank you very much for your review request. There is already a review request in bug 1368855 with a lot of feedback. It would be great if you could help out there if you are still interested in getting radare2 into Fedora.

*** This bug has been marked as a duplicate of bug 1368855 ***