Bug 1450631

Summary:	Octavia diskimage-builder fetches Octavia from stable upstream
Product:	Red Hat OpenStack	Reporter:	Arie Bregman <abregman>
Component:	openstack-octavia	Assignee:	Nir Magnezi <nmagnezi>
Status:	CLOSED ERRATA	QA Contact:	Alexander Stafeyev <astafeye>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	11.0 (Ocata)	CC:	amuller, apevec, astafeye, bcafarel, ihrachys, lhh, lpeer, majopela, mburns, nyechiel, oidgar, tvignaud
Target Milestone:	beta	Keywords:	AutomationBlocker, Triaged
Target Release:	12.0 (Pike)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-octavia-1.0.0-0.20170719072610.208395f.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-13 21:27:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1464073
Bug Blocks:	1454762

Description Arie Bregman 2017-05-14 07:23:20 UTC

Description of problem:

When creating the amphora image with octavia-diskimage-create.sh, it fetches Octavia from stable upstream instead of using the OSP 11 Octavia RPM:

"Caching amphora-agent from https://git.openstack.org/openstack/octavia in /root/.cache/image-create/source-repositories/amphora_agent_4fc13bf1648c049f25ccae0082dd95e0b8b47e0b"


How reproducible: 100%


Steps to Reproduce:
1. Install Octavia OSP 11 RPM
2. Run octavia-diskimage-create.sh -i rhel

Actual results:

"Caching amphora-agent from https://git.openstack.org/openstack/octavia in /root/.cache/image-create/source-repositories/amphora_agent_4fc13bf1648c049f25ccae0082dd95e0b8b47e0b"


Expected results:

Caching amphora-agent from Octavia OSP 11 RPM

Comment 1 Nir Magnezi 2017-05-17 15:57:30 UTC

Good catch Arie!

The reason this is happening is that the diskimage-builder.sh script uses the following element to deploy the amphora-agent (and some more python dependencies):
https://github.com/openstack/octavia/blob/master/elements/amphora-agent/source-repository-amphora-agent

We need to handle this a bit differently in RHEL (and possibly in CentOS).
Instead of the above-mentioned element, we'll need a new element for RHEL which will:
1 Deploy the amphora-agent from an RPM (which is doable, we deploy openstack-selinux from repositories provided by subscription-manager).
2. Configure systemd to start the octavia-amphora-agent.service on boot.

We don't need to handle any additional systemd configuration or python upper-constraints, since we expect the RPM to handle all of that.

Comment 11 Nir Magnezi 2017-07-04 10:04:34 UTC

An update on this fix (which is not currently merged).

Bernard's patch[1] worked okay for me.
I was able to create a RHEL based amphora with diskimage-builder.sh using this patch.
I also managed to successfully create a loadbalancer and a attach a listener. The Amphora Agent is up and running and haproxy got configured and spawned.

[1] https://review.openstack.org/#/c/469850

Comment 14 Nir Magnezi 2017-07-17 06:39:01 UTC

https://review.rdoproject.org/r/#/c/6985 got merged and already included in rhos-12.0-patches
https://review.openstack.org/#/c/469850/ was just merged to u/s master.

Comment 23 errata-xmlrpc 2017-12-13 21:27:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462