Bug 1451187

Summary:	Unknown lvalue 'ENVIRONMENT' in section 'Service while using docker system container
Product:	OpenShift Container Platform	Reporter:	Gan Huang <ghuang>
Component:	Installer	Assignee:	Giuseppe Scrivano <gscrivan>
Status:	CLOSED ERRATA	QA Contact:	Gan Huang <ghuang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-10 05:24:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1450307
Bug Blocks:

Description Gan Huang 2017-05-16 05:36:22 UTC

Description of problem:
According to https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines, `ENVIRONMENT` can't be recognized in systemd service configurations. Only `Environment` recognized.

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.68-1.git.0.9cbe2b7.el7.noarch.rpm

How reproducible:
always

Steps to Reproduce:
1. Set up proxy env while using docker system container
#cat inventory_hosts
<--snip-->
openshift_docker_use_system_container=true
openshift_docker_systemcontainer_image_registry_override=brew-xxx.redhat.com:8888/rhel7
openshift_http_proxy=http://xxx.redhat.com:3128
openshift_https_proxy=http://xxx.redhat.com:3128
<--snip-->



Actual results:
Failed to pull images via docker client from external registry due to proxy variables not loaded into `container-engine` successfully.

# systemctl status container-engine
<--snip-->
May 15 23:51:06 openshift-147.lab.sjc.redhat.com systemd[1]: [/etc/systemd/system/container-engine.service.d/custom.conf:6] Unknown lvalue 'ENVIRONMENT' in section 'Service'

It worked well after renaming 'ENVIRONMENT' to `Environment`.

Expected results:


Additional info:

Comment 1 Giuseppe Scrivano 2017-05-17 09:54:27 UTC

Pull request here:

https://github.com/openshift/openshift-ansible/pull/4214

Comment 3 Gan Huang 2017-06-12 02:56:52 UTC

Verified with openshift-ansible-3.6.98-1.git.0.e651d65.el7.noarch.rpm

Proxy variables set correctly.

Comment 5 errata-xmlrpc 2017-08-10 05:24:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716