Bug 1451977

Summary:	Add logs to identify whether disconnects are voluntary or due to network problems
Product:	[Community] GlusterFS	Reporter:	Milind Changire <mchangir>
Component:	rpc	Assignee:	Milind Changire <mchangir>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs, rgowdapp, rhinduja, rhs-bugs, rtalur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1426125	Environment:
Last Closed:	2017-06-06 06:08:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1426125
Bug Blocks:	1457513

Comment 1 Worker Ant 2017-05-18 04:24:31 UTC

REVIEW: https://review.gluster.org/17321 (rpc: log more about socket disconnects) posted (#2) for review on release-3.10 by Milind Changire (mchangir)

Comment 2 Milind Changire 2017-05-18 17:17:53 UTC

Description of problem:

One of the common problems we encounter are frequent connects/disconnects. Frequent disconnects can be either:

1. voluntary where the process calls a shutdown (2)/close (2) on an otherwise healthy socket connection.
2. involuntary where we get a POLLERR event from network.

While debugging this class of issues, it would help if can identify whether a particular disconnect falls into which of the two above categories. We need to add enough log messages to help us classify.

Comment 3 Worker Ant 2017-05-31 05:57:41 UTC

COMMIT: https://review.gluster.org/17321 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit 86988ace69eefab71eabb54641a7a3cf7c5e6717
Author: Milind Changire <mchangir>
Date:   Thu Feb 23 17:58:46 2017 +0530

    rpc: log more about socket disconnects
    
    Log more about the different paths leading to socket disconnect for
    ease of debugging.
    
    Log via gf_log_callingfn() in __socket_disconnect() at loglevel
    TRACE if socket connection is being torn down.
    
    mainline:
    > BUG: 1426125
    > Signed-off-by: Milind Changire <mchangir>
    > Reviewed-on: https://review.gluster.org/16732
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    (cherry picked from commit 67a35ac54bfd61a920c1919fbde588a04ac3358a)
    
    Change-Id: I1e551c2d685784b5ec747f481179f64d524c0461
    BUG: 1451977
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: https://review.gluster.org/17321
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 4 Raghavendra Talur 2017-06-06 06:08:20 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.3, please open a new bug report.

glusterfs-3.10.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-June/031399.html
[2] https://www.gluster.org/pipermail/gluster-users/