Bug 1452086

Summary: Pagination Size under Customization in IPA WebUI accepts negative values
Product: Red Hat Enterprise Linux 7 Reporter: Sudhir Menon <sumenon>
Component: ipaAssignee: IPA Maintainers <ipa-maint>
Status: CLOSED ERRATA QA Contact: ipa-qe <ipa-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: enewland, fbarreto, frenaud, ksiddiqu, ndehadra, pasik, pvoborni, rcritten, tscherf
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ipa-4.5.4-9.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 16:42:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshots for bug verification none

Description Sudhir Menon 2017-05-18 10:24:13 UTC 
Description of problem: Pagination Size under Customization in IPA WebUI accepts negative value -1


Version-Release number of selected component (if applicable):
ipa-server-4.5.0-9.el7.x86_64

How reproducible: Always

Steps to Reproduce:
1. Install IPA-Server
2. Login to web UI as admin | Navigate to Administrator on RHS corner.
3. Select Customization from the drop down.
4. In the Pagination size text box enter -1 as value.

Actual results:
1. -1 value is accepted in the Pagination size text box and when save button is clicked, Working icon is shown which doesn't finish, with the url address switching back and forth as

https://qe-blade-08.testrelm.test/ipa/ui/#/e/user/search//page=-1
https://qe-blade-08.testrelm.test/ipa/ui/#/e/user/search//page=1

2. Also the http error_log is being appended with the error message

[root@qe-blade-08 ~]# du -sh /var/log/httpd/error_log 
568K	/var/log/httpd/error_log

[root@qe-blade-08 ~]# du -sh /var/log/httpd/error_log 
1.5M	/var/log/httpd/error_log


[Thu May 18 06:15:35.270547 2017] [:warn] [pid 6575] [client 10.76.33.216:39108] failed to set perms (3140) on file (/var/run/ipa/ccaches/admin)!, referer: https://qe-blade-08.testrelm.test/ipa/ui/
[Thu May 18 06:15:35.321164 2017] [:error] [pid 6570] ipa: INFO: [jsonserver_session] admin: user_find(u'', sizelimit=0, version=u'2.224', pkey_only=True): SUCCESS
[Thu May 18 06:15:35.572341 2017] [:warn] [pid 6575] [client 10.76.33.216:39108] failed to set perms (3140) on file (/var/run/ipa/ccaches/admin)!, referer: https://qe-blade-08.testrelm.test/ipa/ui/
[Thu May 18 06:15:35.627594 2017] [:error] [pid 6571] ipa: INFO: [jsonserver_session] admin: user_find(u'', sizelimit=0, version=u'2.224', pkey_only=True): SUCCESS
[Thu May 18 06:15:35.880066 2017] [:warn] [pid 6575] [client 10.76.33.216:39108] failed to set perms (3140) on file (/var/run/ipa/ccaches/admin)!, referer: https://qe-blade-08.testrelm.test/ipa/ui/

3. All the tabs in the UI is affected, i.e data is not displayed, which is correct behaviour since no positive value is specified, once a positive value is given the entries are displayed.

Expected results:
Pagination size should not accept negative values which is causing issues with IPA Web UI.

Additional info:
Comment 2 Petr Vobornik 2017-05-25 16:15:59 UTC 
Upstream ticket:
https://pagure.io/freeipa/issue/6980
Comment 3 Martin Babinsky 2017-07-19 07:28:24 UTC 
Fixed upstream
master:
https://pagure.io/freeipa/c/3cac851498ab85e6b0abf74bc3ff4eea2f960983
https://pagure.io/freeipa/c/cfa157c1e554e0cd113a6fb9fd3af9fbad4529ef
Comment 6 Florence Blanc-Renaud 2018-01-12 15:32:29 UTC 
Moving to ASSIGNED as the backprt to ipa-4-5 was missing
Comment 7 Florence Blanc-Renaud 2018-01-15 17:40:48 UTC 
Fixed upstream
ipa-4-5:
https://pagure.io/freeipa/c/a8aa560f41953295d7224547af386b780c8a88b7
https://pagure.io/freeipa/c/e47872ec43371fc23e85e9c11c5ca9edc9f9aed1
https://pagure.io/freeipa/c/6389bd03e5a93b93d48b81ddfc15c4b41203e9d5
Comment 12 Nikhil Dehadrai 2018-01-25 10:33:05 UTC 
ipa-server-version: ipa-server-4.5.4-9.el7.x86_64

Steps
1. Install IPA-Server
2. Login to web UI as admin | Navigate to Administrator on RHS corner.
3. Select Customization from the drop down.
4. In the Pagination size text box enter -1 as value.
5. Check if negative value is accepted
6. Check httpd/error_log and its size.
7. Check if proper error message is also displayed for:
   - special characters
   - floating numbers / digits
   - alphabets

Verified the bug on the basis of following observation:
1. Verified that negative values are no more accepted, and an appropriate error message is displayed
2. Verified that only integer values are accepted
3. Verified that data is correctly populated across all the tabs as only integer value is accepted.
4. Verified the behavior both for IPA-MASTER and IPA-REPLICA.
5. Verified that the '/var/log/httpd/error_log' are not appended with any constant any Failures messages as only integer value is accepted inside pagination, thus the 'du' command returns appropriate result. 

[root@auto-hv-01-guest04 ~]# du -sh /var/log/httpd/error_log 
28K	/var/log/httpd/error_log

Thus on the basis of above observations , marking the status of bugzilla to 'VERIFIED'
Comment 13 Nikhil Dehadrai 2018-01-25 10:34:01 UTC 
Created attachment 1386012 [details]
Screenshots for bug verification

Screenshots for bug verification
Comment 16 errata-xmlrpc 2018-04-10 16:42:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0918