Bug 1452161

Summary:	Unnecessary access check for created file in open2
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Jiffin <jthottan>
Component:	nfs-ganesha	Assignee:	Jiffin <jthottan>
Status:	CLOSED ERRATA	QA Contact:	Manisha Saini <msaini>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.3	CC:	rhinduja, rhs-bugs, skoduri, storage-qa-internal
Target Milestone:	---
Target Release:	RHGS 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	nfs-ganesha-2.4.4-8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-21 04:47:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1417151

Description Jiffin 2017-05-18 12:59:25 UTC

Description of problem:
For created files, it is not required to check permission again, this can be bypassed by paremeter caller_perm_check passed from open2_by_name but glustefs_open2() was not setting properly

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
Run ftruncate/00.t from posix_testsuite (pjd_fstest) fails for case no 24

Actual results:
test case failed

Expected results:
test case should pass

Additional info:

Comment 2 Jiffin 2017-05-18 13:07:34 UTC

Patch posted upstream https://review.gerrithub.io/#/c/361566/ for review

Comment 6 Manisha Saini 2017-06-12 12:55:46 UTC

Verified this bug on-

# rpm -qa | grep ganesha
nfs-ganesha-gluster-2.4.4-8.el7rhgs.x86_64
nfs-ganesha-debuginfo-2.4.4-8.el7rhgs.x86_64
glusterfs-ganesha-3.8.4-27.el7rhgs.x86_64
nfs-ganesha-2.4.4-8.el7rhgs.x86_64



V3
/home/new_posix/ntfs-3g-pjd-fstest/tests/chown/09.t ...... ok   
/home/new_posix/ntfs-3g-pjd-fstest/tests/chown/10.t ...... ok   
/home/new_posix/ntfs-3g-pjd-fstest/tests/ftruncate/00.t .. ok     
/home/new_posix/ntfs-3g-pjd-fstest/tests/ftruncate/13.t .. ok   


V4

home/new_posix/ntfs-3g-pjd-fstest/tests/chown/09.t ...... ok   
/home/new_posix/ntfs-3g-pjd-fstest/tests/chown/10.t ...... ok   
/home/new_posix/ntfs-3g-pjd-fstest/tests/ftruncate/00.t .. ok     
/home/new_posix/ntfs-3g-pjd-fstest/tests/ftruncate/13.t .. ok   


As no more failure of ftruncate/00.t from posix_testsuite are being observed,hence moving this bug to verified state.

Comment 8 errata-xmlrpc 2017-09-21 04:47:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2779