Bug 1452396
| Summary: | SSUI shows Manage IQ productization | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Matt Pusateri <mpusater> | ||||||
| Component: | UI - Service | Assignee: | Allen W <awight> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Dave Johnson <dajohnso> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.8.0 | CC: | abellott, cpelland, dclarizi, ewinchel, jfrey, jhardy, obarenbo, simaishi, vparekh | ||||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||||
| Target Release: | 5.9.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | ssui: | ||||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1460755 (view as bug list) | Environment: | |||||||
| Last Closed: | 2018-03-06 15:07:14 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1460755 | ||||||||
| Attachments: |
|
||||||||
|
Description
Matt Pusateri
2017-05-18 21:08:10 UTC
Created attachment 1280244 [details]
login screen
Created attachment 1280245 [details]
Header bar
Version 5.8.0.15 Just looking at the bg-login.png file (that's a good one to look at) it seems that all instances of that file (there are 3) are correct. However, looking at where webpack puts things, there is a file that is the incorrect image. This leads me to think that yard build is getting run before the productization files are in place. Issue is here: https://github.com/ManageIQ/manageiq-ui-service/blob/105db14ae4f50df057b5c41c2d834861661df74b/config/webpack.dev.js#L99 If the file is small, and not present before we build, it doesn’t matter what’s in the skin folder, we serve a small URI encoded file. PR incoming. sooooooo after a long day of bagging the head against the keyboard… our core issue with skinning is this. Some assets work and some assets don’t because the assets declarations are different. Declarations from the html with `src` refer to the images folder, which is fine because at the tail end of webpacking that is populated (in miq/public) with the desired skinned contents. Declarations from the sass files however get processed, which happens *before* the skinned assets are copied (but also, these assets look for images in the `client/app/assets/images` folder rather than the `/client/skinned` folder) SO I propose that we reconfigure the symlink to link the `sample-skin/images` folder to the ‘client/app/assets/images` folder in addition to `client/skinned`this will ensure compiled assets used skinned versions. Works for me - once needed change is done on SUI side (change to link.sh?), please assign this BZ to me so I can ensure downstream build makes use of the change. https://github.com/ManageIQ/manageiq-ui-service/pull/790 Satoe, good news, you got nothing to do here, nothing changed with link.sh, essentially reconfigured webpack so that we're now dynamically setting asset urls in sass based on deployment environment, so when we're in production, we'll use the appropriate /images folder assets Verified in 5.9.0.2 *** Bug 1501043 has been marked as a duplicate of this bug. *** |