Bug 1452752

Summary: Some block drivers incorrectly close their associated file
Product: Red Hat Enterprise Linux 7 Reporter: Hanna Czenczek <hreitz>
Component: qemu-kvm-rhevAssignee: Hanna Czenczek <hreitz>
Status: CLOSED ERRATA QA Contact: Ping Li <pingl>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.4CC: aliang, chayang, coli, juzhang, michen, mrezanin, qzhang, virt-maint
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: qemu-kvm-rhev-2.9.0-6.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-02 04:41:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hanna Czenczek 2017-05-19 14:39:33 UTC 
Description of problem:

Some block drivers (namely blkdebug, blkverify, blkreplay) sometiems close their assocated file node if an error occurs during initialization. This is unnecessary, and the way this is done is incorrect, leading to potentially invalid memory accesses.


Version-Release number of selected component (if applicable):

qemu-kvm-rhev-2.9.0-5.el7


How reproducible:

Always.


Steps to Reproduce:

$ qemu-img info --image-opts driver=blkdebug,image.driver=null-co,align=42


Actual results:

[1]    23725 segmentation fault (core dumped)  qemu-img info --image-opts driver=blkdebug,image.driver=null-co,align=42


Expected results:

qemu-img: Could not open 'driver=blkdebug,image.driver=null-co,align=42': Invalid alignment


Additional info:

Fixed in upstream commit de234897b60e034ba94b307fc289e2dc692c9251.
Comment 2 Miroslav Rezanina 2017-05-23 08:16:59 UTC 
Fix included in qemu-kvm-rhev-2.9.0-6.el7
Comment 4 Ping Li 2017-05-24 03:39:58 UTC 
Verified the issue with below packages:
kernel-3.10.0-671.el7.x86_64
qemu-kvm-rhev-2.9.0-6.el7

Test steps:
# qemu-img info --image-opts driver=blkdebug,image.driver=null-co,align=42
qemu-img: Could not open 'driver=blkdebug,image.driver=null-co,align=42': Invalid alignment
Comment 6 errata-xmlrpc 2017-08-02 04:41:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2392