Bug 1454287

Summary:

[RFE] Add UI support to remove a LUNs from a data domain

Product:

[oVirt] ovirt-engine

Reporter:

Liron Aravot <laravot>

Component:

BLL.Storage

Assignee:

shani <sleviim>

Status:

CLOSED CURRENTRELEASE

QA Contact:

Kevin Alon Goldblatt <kgoldbla>

Severity:

high

Docs Contact:

Priority:

high

Version:

future

CC:

bugs, derez, ehildesh, ishaby, laravot, lzitnits, melewis, ratamir, tnisan, troels, ylavi

Target Milestone:

ovirt-4.2.0

Keywords:

FutureFeature

Target Release:

---

Flags:

rule-engine: ovirt-4.2+
ratamir: testing_plan_complete-
ylavi: planning_ack+
rule-engine: devel_ack+
ratamir: testing_ack+

Hardware:

Unspecified

OS:

Unspecified

Whiteboard:

Fixed In Version:

Doc Type:

Enhancement

Doc Text:

Story Points:

---

Clone Of:

1403839

Environment:

Last Closed:

2017-12-20 11:19:19 UTC

Type:

Bug

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

Storage

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

1374545, 1403836, 1403839

Bug Blocks:

633978, 1429746

Attachments:

Description	Flags
Solution 1	none
Solution 2	none
Solution 3 - After a talk with Eldan	none

Description Liron Aravot 2017-05-22 11:51:10 UTC

The support to remove luns from a data domain was added, as first step it was decided to make it usablethrough the rest api only.
This RFE is about adding a dialog to enable doing that through the UI as well or to refactor the current "edit domain" dialog to enable it.

+++ This bug was initially created as a clone of Bug #1403839 +++

Description of problem:
Add the ability to remove LUN(s) from an existing storage domain

--- Additional comment from Liron Aravot on 2016-12-28 02:27:53 EST ---

Allon/Tal, this feature was completely merged but its currently disabled until the issue described in 1403836 will be solved.
How do we want to mark it in bugzilla?

--- Additional comment from Liron Aravot on 2016-12-29 04:54:31 EST ---

After talk with ydary, marking as BLOCKED till the lvmetad issue this bug depends on will be solved either by us (disabling lvmetad) or in lvm.

--- Additional comment from Tal Nisan on 2017-01-12 08:23:40 EST ---

Liron, please fill out a doc text.
As for the other question, I've asked the QE guys to verify this feature with manually disabling lvmetad so they are not blocked on this bug for now

--- Additional comment from Lilach Zitnitski on 2017-03-09 04:00:43 EST ---

--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.1.3-0.1.el7.noarch
vdsm-4.19.7-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. move the storage domain to maintenance 
2. using REST API reduce the lun using it's lun id
3. activate the storage domain

Actual results:
storage domain is reduced and the total space is updated

Expected results:

Moving to VERIFIED!

Comment 8 Idan Shaby 2017-08-08 13:04:43 UTC

Eldan, how do you suggest to do this?
We need a quick UI solution to remove one or more LUNs from a block storage domain.

Comment 9 Eldan Hildesheim 2017-08-23 11:46:29 UTC

Hi,
I will propose 2 solutions:
1. Based on PatternFly, more flexible for adding more features later on. (Perhaps longer to develop)
2. Simple Solution base on current UI, less work but from my opinion less good.

 
Solution 1:
Base on:
http://www.patternfly.org/pattern-library/content-views/table-view/   but without the checkbox.

In this solution all actions are made from the right side (see screenshot):
- Add Luns
- Remove Luns
- Enlarge Lun capacity

If we choose this solution, we will need to change the "New iscsi Domain" Modal as well since adding the luns from there is by checkboxes and we want consistency in between those 2 modals.

Solution 2:
The Remove luns is made by unchecking the checkbox.
This means:
- We need to change a bit the checkbox functionality, today there is a static icon that represents that the Lun in in the Storage Domain.
- Since a checkbox is very easy to uncheck, removing a Lun will be a more easy process which is not a case we want to emphasize.

Comment 10 Eldan Hildesheim 2017-08-23 11:47:10 UTC

Created attachment 1317063 [details]
Solution 1

Comment 11 Eldan Hildesheim 2017-08-23 11:48:59 UTC

Created attachment 1317064 [details]
Solution 2

Comment 12 shani 2017-11-01 16:37:09 UTC

Created attachment 1346632 [details]
Solution 3 - After a talk with Eldan

Comment 13 Kevin Alon Goldblatt 2017-12-10 15:08:53 UTC

Tested with the following code:
--------------------------------
ovirt-engine-4.2.0-0.6.el7.noarch
vdsm-4.20.9-1.el7ev.x86_64


Tested with following scenario:
--------------------------------
1. Created an iscsi storage domain using 2 LUN
2. Set the storage domain to maintenance and detached it
3. Remove one of the LUNs >>>>> successfull


Moving to VERIFIED

Comment 14 Sandro Bonazzola 2017-12-20 11:19:19 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.