Bug 1454375

Summary:	ignore incorrect uuid validation in gd_validate_mgmt_hndsk_req
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1455177 1455182 (view as bug list)		Environment:
Last Closed:	2017-09-05 17:31:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1455177, 1455182

Description Atin Mukherjee 2017-05-22 15:01:46 UTC

Description of problem:

In GlusterD's gd_validate_mgmt_hndsk_req () we ignore failure in fetching uuid from the dictionary to ensure backward compatibility, however the subsequent check still mandate to use peerid parsed from uuid. More details at http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-05-22 15:02:16 UTC

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid validation if uuid_str is empty) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2017-05-23 18:34:40 UTC

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid validation if uuid_str is empty) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Worker Ant 2017-05-24 12:15:10 UTC

COMMIT: https://review.gluster.org/17358 committed in master by Atin Mukherjee (amukherj) 
------
commit b1fbc695a63801a3a2c62738fd6660388123724a
Author: Atin Mukherjee <amukherj>
Date:   Mon May 22 20:23:06 2017 +0530

    glusterd: ignore incorrect uuid validation if uuid_str is empty
    
    If uuid_str is not filled up in dictionary (when glusterd bit is old),
    we shouldn't be additional validation with peer uuid otherwise the
    handshake request will fail.
    
    Refer :
    http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
    Credits : pawan
    
    Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
    BUG: 1454375
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17358
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Prashanth Pai <ppai>

Comment 4 Shyamsundar 2017-09-05 17:31:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/