Bug 1454925
Summary: | Review Request: rtags - A indexer for the c language | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christian Kellner <ckellner> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-09-28 19:57:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Christian Kellner
2017-05-23 19:00:11 UTC
Hello, - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - Release is missing its dist tag: Release: 3%{?dist} - Latest version is no 2.14. Please bump your SPEC accordingly: Version: 2.14 Release: 1%{?dist} > The project's home is on github and releases are done there (via tags), but the project also uses git submodules and these are then not included in the source tarball. You should detail the steps you've made to get to the final archive, or include a script to achieve this. I used git-archive-all to generate the tar.gz, since your SRPM is 404ing. - You're including a user unit file, you thus must run the systemd scripplets in %post, %preun, %postun. See: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd First add the special BR/macro for systemd: %{?systemd_requires} BuildRequires: systemd Then add the scriplets: %post %systemd_post %{name}.service %preun %systemd_preun %{name}.service %postun %systemd_postun_with_restart %{name}.service Anyhow, I'd like an updated SPEC and SRPM to continue the review. Thanks for the review. Updated spec: https://github.com/gicmo/spec/blob/master/rtags/rtags.spec Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21859678 You forgot to include: %postun %systemd_postun_with_restart %{name}.service (In reply to Robert-André Mauchin from comment #3) > You forgot to include: > > %postun > %systemd_postun_with_restart %{name}.service Are you sure? I am using user unit files and this seems to be for non-user unit files. I followed the "user unit" sections ion the guide you linked about. Huh sorry it's late, you're right. I'll finish the review ASAP. Everything checks out, package is accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rtags rtags-2.14-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e4255c54a rtags-2.14-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e4255c54a rtags-2.14-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0869182c22 rtags-2.14-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0869182c22 rtags-2.14-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. rtags-2.14-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |