Bug 1455023

Summary:	Give a warning when using --timeout-postcopy without --postcopy
Product:	Red Hat Enterprise Linux 7	Reporter:	yafu <yafu>
Component:	libvirt	Assignee:	Jiri Denemark <jdenemar>
Status:	CLOSED ERRATA	QA Contact:	zhe peng <zpeng>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.4	CC:	dyuan, fjin, lizhu, rbalakri, xuzhang, yanqzhan, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-3.8.0-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-10 10:44:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description yafu 2017-05-24 05:04:06 UTC

Description of problem:
Since the option --timeout-postcopy does not take effect without option --postcopy, so it's better to give a warning when using --timeout-postcopy without --postcopy.

How reproducible:
100%


Version-Release number of selected component (if applicable):
libvirt-3.2.0-5.virtcov.el7.x86_64
qemu-kvm-rhev-2.9.0-5.el7.x86_64

Steps to reproduce:
#virsh migrate rhel7.3 rhel7.3 qemu+ssh://10.66.144.29/system --live --verbose --timeout-postcopy --timeout 5

Actual results:
Migration completed with precopy.

Expected results:
Give a warning like:
warning: Option --postcopy is required by option --timeout-postcopy

Comment 2 Jiri Denemark 2017-09-11 14:33:15 UTC

Fixed upstream by

commit ecd53ca43a7512621066e6c3c3964b805d3debb1
Refs: v3.7.0-41-gecd53ca43a
Author:     Jiri Denemark <jdenemar>
AuthorDate: Fri Sep 8 18:15:13 2017 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Mon Sep 11 16:29:05 2017 +0200

    virsh: migrate --timeout-postcopy requires --postcopy

    Requesting an automated switch to a post-copy migration (using
    --timeout-postcopy) without actually enabling post-copy migration (using
    --postcopy) doesn't really do anything. Let's make this dependency
    explicit to avoid unexpected behavior.

    https://bugzilla.redhat.com/show_bug.cgi?id=1455023

    Signed-off-by: Jiri Denemark <jdenemar>

Comment 4 zhe peng 2017-11-28 03:31:43 UTC

verify with build:
libvirt-3.9.0-3.el7.x86_64

step:
# virsh migrate --live rhel7.2 qemu+ssh://$target_host/system --verbose --timeout-postcopy --timeout 5
error: Option --postcopy is required by option --timeout-postcopy

Comment 8 errata-xmlrpc 2018-04-10 10:44:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0704