Bug 1455154

Summary: Error refreshing manifest. wrong number of arguments (2 for 1)
Product: Red Hat Satellite Reporter: Evgeni Golov <egolov>
Component: Subscription ManagementAssignee: Justin Sherrill <jsherril>
Status: CLOSED ERRATA QA Contact: Roman Plevka <rplevka>
Severity: high Docs Contact:
Priority: high    
Version: 6.2.10CC: bbuckingham, bkearney, jcallaha, jsherril, rplevka
Target Milestone: UnspecifiedKeywords: Regression, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: rubygem-katello- Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-20 17:24:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Description Flags
log of the issue none

Description Evgeni Golov 2017-05-24 11:20:40 UTC
Created attachment 1281920 [details]
log of the issue

Description of problem:
When trying to refresh a manifest on 6.2.10-1.0, the UI just shows "Error refreshing manifest. wrong number of arguments (2 for 1)"
production.log excerpt is attached.

The problem seems to be that the refresh is calling the owner_regenerate_upstream_certificates function, which is defined as:
def owner_regenerate_upstream_certificates(upstream)
but we're calling it with two options
:action => [self, :owner_regenerate_upstream_certificates, upstream, options]

Version-Release number of selected component (if applicable):
6.2.10 Snap 1.0

How reproducible:

Steps to Reproduce:
1. refresh manifest

Actual results:

Expected results:
manifest is refreshed

Additional info:

Comment 2 Evgeni Golov 2017-05-24 12:29:32 UTC
The obvious patch that *seems* to fix it is:

% git diff
diff --git a/app/models/katello/glue/provider.rb b/app/models/katello/glue/provider.rb
index ea408f2..2101aba 100644
--- a/app/models/katello/glue/provider.rb
+++ b/app/models/katello/glue/provider.rb
@@ -223,7 +223,7 @@ module Katello
             zip_file_path = "/tmp/#{rand}.zip"
             upstream = options[:upstream]
             pre_queue.create(:name => "regenerate upstream certificates for: #{self.organization.name}",
-                             :priority => 1, :action => [self, :owner_regenerate_upstream_certificates, upstream, options],
+                             :priority => 1, :action => [self, :owner_regenerate_upstream_certificates, upstream],
                              :action_rollback => nil)
             pre_queue.create(:name => "export upstream manifest for owner: #{self.organization.name}",
                              :priority => 2, :action => [self, :owner_upstream_update, upstream, options],

Comment 4 Roman Plevka 2017-05-29 10:52:53 UTC
VERIFIED on 6.2.10-2 by QA automation:

No issues detected while refreshing a manifest

Comment 6 errata-xmlrpc 2017-06-20 17:24:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.