Bug 1455179

Summary:	[Geo-rep]: Log time taken to sync entry ops, metadata ops and data ops for each batch
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-05 17:32:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kotresh HR 2017-05-24 12:22:32 UTC

Description of problem:
It's very useful, if we have the sync time for entry ops, metadata ops and
data ops in each batch for performance analysis. Along with sync time, we
can also have the count and type of fops as well.

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-05-24 12:26:26 UTC

REVIEW: https://review.gluster.org/17066 (geo-rep: Log time taken to sync entries) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 2 Worker Ant 2017-05-25 08:30:42 UTC

REVIEW: https://review.gluster.org/17066 (geo-rep: Log time taken to sync entries) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 3 Worker Ant 2017-05-29 06:44:12 UTC

COMMIT: https://review.gluster.org/17066 committed in master by Aravinda VK (avishwan) 
------
commit de3368a53d9b2d8e035fe070c011a1b78d34559a
Author: Kotresh HR <khiremat>
Date:   Mon Apr 10 02:04:42 2017 -0400

    geo-rep: Log time taken to sync entries
    
    With each batch having the type and count of
    each fop helps to know the kind of I/O.
    Having time taken to sync entry ops, metadata
    ops and data ops gives us good understanding
    into where the more time is being spent.
    This patch does the same.
    
    Change-Id: Ib52a0f9ede905f28a468b68bdf6d23e4b043f3e3
    BUG: 1455179
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: https://review.gluster.org/17066
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Aravinda VK <avishwan>

Comment 4 Worker Ant 2017-06-13 09:17:01 UTC

REVIEW: https://review.gluster.org/17531 (geo-rep: Added metrics related to Sync Time) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 5 Worker Ant 2017-06-15 07:21:00 UTC

COMMIT: https://review.gluster.org/17531 committed in master by Aravinda VK (avishwan) 
------
commit b1a6297ec323bfda27068b9579d2848cd8f48b0d
Author: Aravinda VK <avishwan>
Date:   Tue Jun 13 14:40:09 2017 +0530

    geo-rep: Added metrics related to Sync Time
    
    In Geo-rep, Sync jobs can be configured using, `config sync-jobs 3`. This
    patch adds following information related to the sync job(Rsync/Tarssh)
    
    Example output:
    
        [2017-06-13 09:09:32.532181] I [master(/bricks/b1):1713:syncjob] Syncer: \
            Sync Time Taken (Job:2 Files:5484 ReturnCode:0): 4.8774 secs
    
    Change-Id: Ifceb96d4b8d14e00fd1290c0aeff60d64b4d7f37
    BUG: 1455179
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: https://review.gluster.org/17531
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>

Comment 6 Shyamsundar 2017-09-05 17:32:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/